Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Upgrade mocha from 4.1.0 to 5.2.0 #133

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Upgrade mocha from 4.1.0 to 5.2.0 #133

merged 2 commits into from
Jun 19, 2019

Conversation

cgewecke
Copy link
Owner

@cgewecke cgewecke commented Jun 19, 2019

#132

v6.0.0 triggers an epilogue crash and needs investigation. Not obvious from the release notes why this might happen.

/home/travis/build/cgewecke/eth-gas-reporter/mock/node_modules/mocha/lib/reporters/base.js:319
  console.log(fmt, stats.passes || 0, milliseconds(stats.duration));
                         ^
TypeError: Cannot read property 'passes' of undefined

TBH mocha shouldn't be a dependency here but there have been strange issues with how mocha is scoped (locally vs. globally) relative to truffle, which ships with mocha as an un-webpacked dep. See #42.

@cgewecke cgewecke changed the title Upgrade mocha from 4.1.0 to 6.1.4 Upgrade mocha from 4.1.0 to 5.2.0 Jun 19, 2019
@cgewecke cgewecke merged commit bfe4783 into master Jun 19, 2019
@cgewecke cgewecke deleted the bump-mocha branch June 19, 2019 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant