Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] [Router] Incorporate React-Router links into the DSR #117

Closed
billhimmelsbach opened this issue Jan 3, 2024 · 0 comments · Fixed by cfpb/design-system-react#294
Closed

[Task] [Router] Incorporate React-Router links into the DSR #117

billhimmelsbach opened this issue Jan 3, 2024 · 0 comments · Fixed by cfpb/design-system-react#294
Assignees
@billhimmelsbach
Labels
refactor Candidates for future refactor sprints

Comments

@billhimmelsbach
Copy link
Contributor

billhimmelsbach commented Jan 3, 2024 •
edited
Loading

Investigate converting links one ones that work with ReactRouterDom for snappier UX, see this PR

EDIT: I demoed this at sprint review this week, and I'll be implementing this into the DSR this week for both Links and NavLinks
@billhimmelsbach billhimmelsbach added the refactor Candidates for future refactor sprints label Jan 3, 2024
@billhimmelsbach billhimmelsbach self-assigned this Jan 3, 2024
@billhimmelsbach billhimmelsbach changed the title [Task] [Router] Most Links -> RouterLinks [Task] [Router] Router links wrapper Jan 3, 2024
@billhimmelsbach billhimmelsbach changed the title [Task] [Router] Router links wrapper [Task] [Router] Incorporate React-Router links into the DSR Jan 18, 2024
@billhimmelsbach billhimmelsbach mentioned this issue Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billhimmelsbach billhimmelsbach

Labels
refactor Candidates for future refactor sprints
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Link): add react-router link integration cfpb/design-system-react
1 participant
@billhimmelsbach