Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: Refactor how services are stored on the node #304

Closed
Tracked by #944
renaynay opened this issue Dec 20, 2021 · 2 comments
Closed
Tracked by #944

node: Refactor how services are stored on the node #304

renaynay opened this issue Dec 20, 2021 · 2 comments
Assignees
Labels
architecture Architecture / design-related issues area:node Node

Comments

@renaynay
Copy link
Member

Right now, services are stored as such on the node:

        BlockServ  *block.Service  `optional:"true"`
	ShareServ  share.Service   // not optional
	HeaderServ *header.Service // not optional

Sometimes, the services are nil (for Bridge and Light node, block service will always be nil, for example), while ShareServ is an interface -- it's not uniform.


Proposed solution:

Store the lifecycles on the node rather than the actual services themselves as the node doesn't necessarily need to care about its services, just needs to be able to start and stop them (which is done with the fx app anyway at the moment).

@renaynay renaynay added the area:node Node label Dec 20, 2021
@renaynay renaynay added the architecture Architecture / design-related issues label Apr 26, 2022
@renaynay
Copy link
Member Author

Related to #506

@renaynay
Copy link
Member Author

renaynay commented Nov 9, 2022

No longer an issue thanks to turning everything into a Module

@renaynay renaynay closed this as completed Nov 9, 2022
Repository owner moved this from TODO to Done in Celestia Node Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Architecture / design-related issues area:node Node
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants