You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, services are stored as such on the node:
BlockServ *block.Service `optional:"true"`
ShareServ share.Service // not optional
HeaderServ *header.Service // not optional
Sometimes, the services are nil (for Bridge and Light node, block service will always be nil, for example), while ShareServ is an interface -- it's not uniform.
Proposed solution:
Store the lifecycles on the node rather than the actual services themselves as the node doesn't necessarily need to care about its services, just needs to be able to start and stop them (which is done with the fx app anyway at the moment).
The text was updated successfully, but these errors were encountered:
Right now, services are stored as such on the node:
Sometimes, the services are nil (for
Bridge
andLight
node, block service will always be nil, for example), whileShareServ
is an interface -- it's not uniform.Proposed solution:
Store the lifecycles on the node rather than the actual services themselves as the node doesn't necessarily need to care about its services, just needs to be able to start and stop them (which is done with the fx app anyway at the moment).
The text was updated successfully, but these errors were encountered: