Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nodebuilder): clean up Config usage pattern #1287

Closed
Tracked by #944
distractedm1nd opened this issue Oct 28, 2022 · 1 comment
Closed
Tracked by #944

fix(nodebuilder): clean up Config usage pattern #1287

distractedm1nd opened this issue Oct 28, 2022 · 1 comment
Labels
area:node Node kind:misc Attached to miscellaneous PRs

Comments

@distractedm1nd
Copy link
Collaborator 

    We need to clean up Config usage pattern in our module configs. Somewhere we use ptr, and somewhere a value. Let's use ptr everywhere.

Originally posted by @Wondertan in #1199 (comment)
@distractedm1nd distractedm1nd added area:node Node kind:misc Attached to miscellaneous PRs labels Oct 28, 2022
This was referenced Oct 28, 2022
Closed
Merged
@renaynay
Copy link
Member

renaynay commented Nov 3, 2022

Issue is resolved, we use ptr everywhere in config / cfg.Validate pattern throughout nodebuilder subpkgs.

@renaynay renaynay closed this as completed Nov 3, 2022
@renaynay renaynay moved this to TODO in Celestia Node Nov 3, 2022
@renaynay renaynay moved this from TODO to Done in Celestia Node Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:node Node kind:misc Attached to miscellaneous PRs
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@distractedm1nd @renaynay