Decide what to do about missing logging flags for the start sub-command

[evan-forbes]

Logging has been refactored in the cosmos-sdk. Starport apps have yet to be updated accordingly, so these flags have to be manually added to the start sub-command in order to pass the logging configurations to lazyledger-core.

I see two very easy solutions to this, we could

1. add the flags to the start cmd in the lazyledger fork of the cosmos-sdk
2. add the flags outside of the sdk in the lazyledger-app
3. Something else that I'm not seeing (@marbar3778 @liamsi)

Ideally, we would add them to the cosmos-sdk, right next to other start sub-command flags. However, any changes we make to the sdk will have to be undone each time we upstream anything.

[tac0turtle]

Weird. I always assumed it was there. On tendermint we have this as a global flag on the start cmd. I dont have a preference, whichever is easiest.

We should open an issue on the cosmos-sdk to add support this as well. If you decide to add it on the sdk side you can also look at upstreaming the change.

[liamsi]

ref: cosmos/cosmos-sdk#8143, tendermint/tendermint#5912

[evan-forbes]

Ok, I found out exactly what was wrong after talking with @liamsi and a little more digging. The cosmos-sdk is adding the flags when calling Execute. The lazyledger-app call's its own Execute. Therefore, it makes sense to add the flags to the lazyledger-app's Execute function in the same fashion. This was changed in starport v0.13.2, so we don't need to upstream anything.