-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nixos): add support for gitea/forgejo #179
Conversation
c9b66cb
to
e40383c
Compare
5a0d6e1
to
8daa228
Compare
This should now be possible! |
8daa228
to
8593b37
Compare
8bdf267
to
46c4804
Compare
46c4804
to
0a11249
Compare
modules/lib/default.nix
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't say I'm a fan of introducing a general consts
just for this
Maybe access them through types.flavors.functor.payload.values
instead?
Now that I type it out it does sound a bit silly, though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't a fan either hence I wanted to prompt you for a review. Strictly speaking we could drop it again and use IFD. But I'd rather avoid introducing more IFD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think types.flavors.functor.payload.values
would be fine for now then, even though it's super ugly
If more ports end up using it later, I'd be fine with a consts
0a11249
to
d66a8e8
Compare
Sorry for the wait again, I've been setting up my own Forgejo instance for a little bit and figured it would be the perfect place to test this out. I'll hopefully get to it soon :p |
89571e2
to
1d8bd1e
Compare
1d8bd1e
to
0f15aaf
Compare
On this note. Just deployed my git instance with the theme and it works perfectly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the following applied it works on my Forgejo instance as well :)
Co-authored-by: seth <getchoo@tuta.io> Co-authored-by: isabel <isabel@isabelroses.com>
0f15aaf
to
36282ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work @Lichthagel and @isabelroses. Sorry for the long wait, too
Requires fetching release artifacts or building the theme from source (similar to #149)