Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nixos): add support for gitea/forgejo #179

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

Lichthagel
Copy link
Contributor

Requires fetching release artifacts or building the theme from source (similar to #149)

@Lichthagel Lichthagel force-pushed the feat/gitea-forgejo branch from c9b66cb to e40383c Compare May 20, 2024 11:16
@getchoo getchoo added the blocked Waiting on external changes label May 21, 2024
@Lichthagel Lichthagel force-pushed the feat/gitea-forgejo branch 2 times, most recently from 5a0d6e1 to 8daa228 Compare May 22, 2024 09:12
@getchoo getchoo added this to the 2.0.0 milestone Nov 27, 2024
@isabelroses isabelroses removed the blocked Waiting on external changes label Dec 30, 2024
@isabelroses
Copy link
Member

This should now be possible!

@isabelroses isabelroses marked this pull request as ready for review January 6, 2025 17:13
@isabelroses isabelroses force-pushed the feat/gitea-forgejo branch 2 times, most recently from 8bdf267 to 46c4804 Compare January 6, 2025 17:33
@isabelroses isabelroses requested a review from getchoo January 12, 2025 19:39
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I'm a fan of introducing a general consts just for this

Maybe access them through types.flavors.functor.payload.values instead?
Now that I type it out it does sound a bit silly, though...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't a fan either hence I wanted to prompt you for a review. Strictly speaking we could drop it again and use IFD. But I'd rather avoid introducing more IFD.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think types.flavors.functor.payload.values would be fine for now then, even though it's super ugly

If more ports end up using it later, I'd be fine with a consts

@getchoo
Copy link
Member

getchoo commented Feb 11, 2025

Sorry for the wait again, I've been setting up my own Forgejo instance for a little bit and figured it would be the perfect place to test this out. I'll hopefully get to it soon :p

@isabelroses isabelroses force-pushed the feat/gitea-forgejo branch 3 times, most recently from 89571e2 to 1d8bd1e Compare February 17, 2025 19:02
@isabelroses
Copy link
Member

Sorry for the wait again, I've been setting up my own Forgejo instance for a little bit and figured it would be the perfect place to test this out. I'll hopefully get to it soon :p

On this note. Just deployed my git instance with the theme and it works perfectly.

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the following applied it works on my Forgejo instance as well :)

Co-authored-by: seth <getchoo@tuta.io>
Co-authored-by: isabel <isabel@isabelroses.com>
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work @Lichthagel and @isabelroses. Sorry for the long wait, too

@getchoo getchoo merged commit b1ff2a6 into catppuccin:main Feb 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants