add support for helix #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Helix bundles the Catppuccin themes by default, is there any reason to add them here? |
|
i would like to say it was for customization...but honestly i misread the README and didn't catch that they were included (i don't use helix myself, it was just an easy theme that came to mind) i still think fetching the repository could be a good idea though since it allows users to choose between the variants. if that's not good though, i'll just take out the theme declaration while leaving the settings |
|
Oh yeah, I forgot about the no-italics variant. I'll merge this then. |
Stonks3141
approved these changes
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds support for the helix theme