Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Pyserini requirements Optional #193

Open
sahel-sh opened this issue Feb 18, 2025 · 2 comments
Open

Make Pyserini requirements Optional #193

sahel-sh opened this issue Feb 18, 2025 · 2 comments
Assignees
@nihalmenon
Labels
good first issue Good for newcomers help appreciated :D

Comments

@sahel-sh
Copy link
Member

Since the main user journey is for users to bring their own retrieved data in json(l) format, pyserini integraiton and its dependencies should be optional.

Sample reference:
check how vllm imports and requirements are handled in the code.
@nihalmenon
Copy link
Contributor

I'm interested in working on this! Started here.

@sahel-sh
Copy link
Member Author

Thanks @nihalmenon, it is yours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nihalmenon nihalmenon

Labels
good first issue Good for newcomers help appreciated :D
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sahel-sh @nihalmenon