Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SPG::AddScan return the inserted node id. #617

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Make SPG::AddScan return the inserted node id. #617

merged 1 commit into from
Nov 2, 2017

Conversation

ojura
Copy link
Contributor

@ojura ojura commented Oct 30, 2017

#574 depends on this.

This was referenced Oct 30, 2017
Merged
Merged
@wohe wohe merged commit c57641f into cartographer-project:master Nov 2, 2017
@ojura ojura deleted the spg-return-nodeid branch November 2, 2017 09:37
wally-the-cartographer pushed a commit that referenced this pull request Nov 10, 2017
@ojura @wally-the-cartographer
Introduce MatchingResult for LocalTrajectoryBuilder::AddRangeData. (#619
eb4415d 
)

In preparation for #574. Depends on ~~#618~~ (merged) and ~~#617~~ (merged).
wally-the-cartographer pushed a commit that referenced this pull request Nov 14, 2017
@ojura @wally-the-cartographer
Add local SLAM result callback. (#574)
818e5e1 
Depends on ~~#619~~ (merged) and ~~#617~~ (merged).
Related to #508.

Also, if cartographer_ros is going to use this, and we wish to serialize the saved range data, that will have to be handled in cartographer_ros, right?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wohe wohe wohe approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ojura @wohe @googlebot