Skip to content

Commit ad69e7e

Browse files
authored
Add memcached to db.system semantic conventions (open-telemetry#1689)
* Add memcached to db.system semantic conventions As we already use `memcached` to represent the `db.system` Memcached in opentelemetry-python, I believe we should add to the specification recommendation https://github.com/open-telemetry/opentelemetry-python-contrib/blob/e606542981580971af1bbecbf07671c39f799665/instrumentation/opentelemetry-instrumentation-pymemcache/src/opentelemetry/instrumentation/pymemcache/__init__.py#L160
1 parent a651711 commit ad69e7e

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ release.
2323

2424
- Add JSON RPC specific conventions ([#1643](https://github.com/open-telemetry/opentelemetry-specification/pull/1643)).
2525

26+
- Add Memcached to Database specific conventions ([#1689](https://github.com/open-telemetry/opentelemetry-specification/pull/1689)).
27+
2628
### Compatibility
2729

2830
### OpenTelemetry Protocol

semantic_conventions/trace/database.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,9 @@ groups:
147147
- id: elasticsearch
148148
value: 'elasticsearch'
149149
brief: 'Elasticsearch'
150+
- id: memcached
151+
value: 'memcached'
152+
brief: 'Memcached'
150153
- id: connection_string
151154
tag: connection-level
152155
type: string

specification/trace/semantic_conventions/database.md

+1
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ Some database systems may allow a connection to switch to a different `db.user`,
106106
| `neo4j` | Neo4j |
107107
| `geode` | Apache Geode |
108108
| `elasticsearch` | Elasticsearch |
109+
| `memcached` | Memcached |
109110
<!-- endsemconv -->
110111

111112
### Notes and well-known identifiers for `db.system`

0 commit comments

Comments
 (0)