Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: data-* attributes produce type errors using svelte-check version 3 #1740

Closed
metonym opened this issue Jun 4, 2023 · 1 comment
Closed

TypeScript: data-* attributes produce type errors using svelte-check version 3 #1740

metonym opened this issue Jun 4, 2023 · 1 comment
Assignees
@metonym
Labels
bug Something isn't working typescript TypeScript-related pain point

Comments

@metonym
Copy link
Collaborator

metonym commented Jun 4, 2023 •
edited
Loading

Flagged in Discord: https://discord.com/channels/689212587170201628/1048235099583418448/threads/1112376518862188675

See sveltejs/language-tools#1825

Many components forward $$restProps to the underlying HTML element. Data attributes (e.g., data-test-id) should be valid.

svelte-check version 3 applies a new transform which marks data-* attributes as errors.

This library still uses svelte-check version 2; the first step would be to upgrade svelte-check to the latest version to reproduce this error. See #1739

Screen Shot 2023-06-04 at 8 07 10 AM
@metonym metonym added bug Something isn't working typescript TypeScript-related pain point labels Jun 4, 2023
@metonym metonym self-assigned this Jun 4, 2023
This was referenced Jun 4, 2023
Merged
Merged
@metonym
Copy link
Collaborator Author

metonym commented Jul 9, 2023

Fixed by #1741, available in v0.76.1

@metonym metonym closed this as completed Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metonym metonym

Labels
bug Something isn't working typescript TypeScript-related pain point
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@metonym