Ensure ca_file is closed

sabaini · sabaini · commit 46622911a4af · 2024-02-12T09:59:58.000+01:00
Signed-off-by: Peter Sabaini &lt;peter.sabaini@canonical.com&gt;
diff --git a/lib/charms/mysql/v0/s3_helpers.py b/lib/charms/mysql/v0/s3_helpers.py
@@ -85,6 +85,8 @@ def upload_content_to_s3(content: str, content_path: str, s3_parameters: Dict) -
             exc_info=e,
         )
         return False
+    finally:
+        ca_file.close()
 
     return True
 

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,8 @@ def upload_content_to_s3(content: str, content_path: str, s3_parameters: Dict) -`
`85`	`85`	`exc_info=e,`
`86`	`86`	`)`
`87`	`87`	`return False`
	`88`	`+ finally:`
	`89`	`+ ca_file.close()`
`88`	`90`
`89`	`91`	`return True`
`90`	`92`