Skip to content

Commit cfba4c8

Browse files
committed
build(tests): fix tests
Refs: #131
1 parent 054c49e commit cfba4c8

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

automatoes/crypto.py

+8-1
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,15 @@ def load_pem_certificate(data):
228228
return x509.load_pem_x509_certificate(data, default_backend())
229229

230230

231+
def get_issuer_certificate_domain_name(cert):
232+
for cn in cert.subject:
233+
return cn.value
234+
235+
231236
def get_certificate_domain_name(cert):
232-
return cert.subject.get_attributes_for_oid(NameOID.COMMON_NAME)[0].value
237+
for ext in cert.extensions:
238+
if isinstance(ext.value, SubjectAlternativeName):
239+
return ext.value.get_values_for_type(DNSName)[0]
233240

234241

235242
def get_certificate_domains(cert):

tests/features/steps/acme_v2_steps.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818
from behave import given, when, then
1919
from automatoes.crypto import (create_csr, generate_rsa_key,
2020
strip_certificates, load_pem_certificate,
21-
get_certificate_domain_name)
21+
get_certificate_domain_name,
22+
get_issuer_certificate_domain_name)
2223
from automatoes.model import Account
2324
from cartola import security
2425

@@ -169,7 +170,7 @@ def step_order_has_a_certificate_with_domain(context, what_domain):
169170
)
170171
issuer_certificate = load_pem_certificate(certificates[1])
171172
context.tester.assertTrue(
172-
get_certificate_domain_name(
173+
get_issuer_certificate_domain_name(
173174
issuer_certificate
174175
).startswith("Pebble Intermediate CA")
175176
)

0 commit comments

Comments
 (0)