Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] ModelManager is always used in the ChatAgent. However, it is not necessary and the error message in ModelManager is confucing for the users. Let's just use a default BaseModelBackend from ModelFactory #1682

Closed
lightaime opened this issue Mar 2, 2025 · 2 comments · Fixed by #1719
Closed

[Feature Request] ModelManager is always used in the ChatAgent. However, it is not necessary and the error message in ModelManager is confucing for the users. Let's just use a default BaseModelBackend from ModelFactory #1682

lightaime opened this issue Mar 2, 2025 · 2 comments · Fixed by #1719
Assignees
@mohamadkav @Wendong-Fan
Labels
enhancement New feature or request
Milestone
Sprint 24

Comments

@lightaime
Copy link
Member

No description provided.

@Wendong-Fan Wendong-Fan self-assigned this Mar 3, 2025
@Wendong-Fan Wendong-Fan added the enhancement New feature or request label Mar 3, 2025
@Wendong-Fan Wendong-Fan added this to the Sprint 24 milestone Mar 3, 2025
@Wendong-Fan Wendong-Fan changed the title ModelManager is always used in the ChatAgent. However, it is not necessary and the error message in ModelManager is confucing for the users. Let's just use a default BaseModelBackend from ModelFactory [Feature Request] ModelManager is always used in the ChatAgent. However, it is not necessary and the error message in ModelManager is confucing for the users. Let's just use a default BaseModelBackend from ModelFactory Mar 3, 2025
@mohamadkav mohamadkav self-assigned this Mar 4, 2025
@mohamadkav
Copy link
Collaborator

Can you explain what error message you are talking about? Also, ModelManager is only used once in ChatAgent, and that is when there is no model provided.

@Wendong-Fan Wendong-Fan linked a pull request Mar 5, 2025 that will close this issue
chore: Update ModelManager error message for one model #1719
Merged
6 tasks
@Wendong-Fan
Copy link
Member

Thanks @mohamadkav , I updated on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohamadkav mohamadkav

@Wendong-Fan Wendong-Fan

Labels
enhancement New feature or request
Projects
Project Camel
Status: No status
Milestone
Sprint 24
Development

Successfully merging a pull request may close this issue.

chore: Update ModelManager error message for one model camel-ai/camel
3 participants
@mohamadkav @lightaime @Wendong-Fan