Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Unify data models under data_schemas folder #1316

Open
1 of 2 tasks
Wendong-Fan opened this issue Dec 13, 2024 · 6 comments · May be fixed by #1648
Open
1 of 2 tasks

[Feature Request] Unify data models under data_schemas folder #1316

Wendong-Fan opened this issue Dec 13, 2024 · 6 comments · May be fixed by #1648
Assignees
@boerz-coding
Labels
enhancement New feature or request good first issue Good for newcomers P0 Task with high level priority
Milestone
Sprint 21

Comments

@Wendong-Fan
Copy link
Member

Wendong-Fan commented Dec 13, 2024 •
edited by lightaime
Loading

Required prerequisites

Motivation

there's some data models defined in camel/data_collector and camel/messages/conversion/conversation_models.py, we can unify these data models under one data_schemas folder to make the structure better, there's also some duplication can be reduced

Solution

No response

Alternatives

No response

Additional context

No response
@Wendong-Fan Wendong-Fan added enhancement New feature or request call for contribution P0 Task with high level priority labels Dec 13, 2024
@Wendong-Fan Wendong-Fan mentioned this issue Dec 13, 2024
Merged
13 tasks
@Wendong-Fan Wendong-Fan added the good first issue Good for newcomers label Dec 13, 2024
@Wendong-Fan Wendong-Fan added this to the Sprint 19 milestone Dec 15, 2024
@Wendong-Fan
Copy link
Member Author

@mustardBloom

@Wendong-Fan Wendong-Fan modified the milestones: Sprint 19, Sprint 20 Dec 30, 2024
@Wendong-Fan Wendong-Fan modified the milestones: Sprint 20, Sprint 21 Jan 13, 2025
@Wendong-Fan Wendong-Fan changed the title [Feature Request] Unify data models under date_models folder [Feature Request] Unify data models under date_schemas folder Jan 20, 2025
@boerz-coding
Copy link
Collaborator

boerz-coding commented Jan 20, 2025 •
edited
Loading

Hi @Wendong-Fan I am interested in contributing to this. Btw should we name it as data_schemas rather than date_schemas?

@lightaime lightaime changed the title [Feature Request] Unify data models under date_schemas folder [Feature Request] Unify data models under data_schemas folder Jan 20, 2025
@lightaime
Copy link
Member

Thanks @boerz-coding for your interest. Please feel free to give it a try. It is a typo. Please name it as data_schemas!

@boerz-coding boerz-coding self-assigned this Jan 20, 2025
@Wendong-Fan
Copy link
Member Author

hey @boerz-coding , any updates on this item or anything I can support?

@boerz-coding
Copy link
Collaborator

Hi @Wendong-Fan, thank you for following up! I apologize for the delay—I’ve been a bit tied up over the past few weeks. I’m actively working on this now and aiming to have it completed by the end of this week. Thank you for your patience!

@boerz-coding
Copy link
Collaborator

I am still working on this issue and should be able to submit my commit in a few days!

@boerz-coding boerz-coding linked a pull request Feb 24, 2025 that will close this issue
Open
6 tasks
@Wendong-Fan Wendong-Fan linked a pull request Feb 24, 2025 that will close this issue
refactor: Refactor data models #1648
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boerz-coding boerz-coding

Labels
enhancement New feature or request good first issue Good for newcomers P0 Task with high level priority
Projects
Project Camel
Status: No status
Milestone
Sprint 21
Development

Successfully merging a pull request may close this issue.

refactor: Refactor data models boerz-coding/camel
3 participants
@lightaime @boerz-coding @Wendong-Fan