Make changes to prevent plugins referencing non existing APIs from

being created

Fix another race condition because I misunderstood the return type

Author: cfernandes

bin/operations/synchronization.js

@@ -162,7 +162,21 @@ module.exports = async function synchronization(filename, url, username, passwor
     await delay(waitTimeInMs);
 
     console.log('Updating Plugins'.bold);
-    const pendingPluginCreations = diskPlugins.map(async eachPlugin => await kong.plugins.createOrUpdatePlugin(eachPlugin));
+    const pendingPluginCreations = diskPlugins.map(async eachPlugin => {
+      if (eachPlugin.api_id) {
+        // this is a plugin that applies to a specific API
+        // check whether the API exists before applying the plugin
+        const apiInformation = await kong.apis.apiDetails(eachPlugin.api_id).catch(() => undefined);
+        if (apiInformation) {
+          return await kong.plugins.createOrUpdatePlugin(eachPlugin)
+        } else {
+          console.log(`WARNING: Plugin ${eachPlugin.name} points to an API ID ${eachPlugin.api_id} that does not exist`.grey);
+          return Promise.resolve(0);
+        }
+      } else {
+        return await kong.plugins.createOrUpdatePlugin(eachPlugin)
+      }
+    });
     await Promise.all(pendingPluginCreations);
     console.log('Plugin updates complete'.green);
 

lib/kong/entities/apis.js

@@ -53,6 +53,7 @@ module.exports = function kongApis(connectionContext) {
 
     return {
         allApis: apis,
+        api,
         createOrUpdateApi,
         removeApi
     }

lib/kong/entities/consumers.js

@@ -121,7 +121,7 @@ module.exports = function kongConsumers(connectionContext) {
         }, {}, authPlugins);
 
         const pluginsDataWithoutBasicAuth = dissoc('basic-auth', plugins);
-        return authPlugins
+        const result = authPlugins
             .filter(pluginName => pluginName !== 'basic-auth')
             .filter(pluginName => pluginsDataWithoutBasicAuth[pluginName].length > 0)
             .map(pluginName => {
@@ -133,6 +133,7 @@ module.exports = function kongConsumers(connectionContext) {
                   credentialList.map(async credential => await deleteAdminRequest(`consumers/${consumerNameOrId}/${pluginName}`, credential.id))
                 )
             );
+        return await Promise.all(result);
     }
 
     return {

lib/kong/index.js

@@ -7,7 +7,7 @@ const kongCertificates = require('./entities/certificates');
 const kongSNIs = require('./entities/snis');
 
 module.exports = function kong(connectionContext) {
-    const {allApis, createOrUpdateApi, removeApi} = kongApis(connectionContext);
+    const {allApis, createOrUpdateApi, removeApi, api} = kongApis(connectionContext);
     const {plugin, plugins, createOrUpdatePlugin, removePlugin} = kongPlugins(connectionContext);
     const {consumers, consumerDetails, consumersWithAuthentication, createOrUpdateConsumerWithCredentials,
         removeConsumerWithCredentials, cleanConsumerWithCredentials} = kongConsumers(connectionContext);
@@ -18,7 +18,8 @@ module.exports = function kong(connectionContext) {
         apis: {
             allApis,
             createOrUpdateApi,
-            removeApi
+            removeApi,
+            apiDetails: api
         },
         plugins: {
             pluginsForApi: plugin,