chore: remove the sidebar_loaded event

adhorodyski · adhorodyski · commit f50765a6c83b · 2024-10-31T17:36:22.000+01:00
diff --git a/contributingGuides/PERFORMANCE_METRICS.md b/contributingGuides/PERFORMANCE_METRICS.md
@@ -14,7 +14,6 @@ Project is using Firebase for tracking these metrics. However, not all of them a
 | `js_loaded`    | ✅ | The time it takes for the JavaScript bundle to load. <br><br>**Platforms:** Android, iOS | **Android:** Starts in the `onCreate` method.<br><br>**iOS:** Starts in the AppDelegate's `didFinishLaunchingWithOptions` method.    | Stops at the first render of the app via native module on the JS side.     |
 | `_app_in_foreground`    | ✅ | The time when the app is running in the foreground and available to the user.<br><br>**Platforms:** Android, iOS     | **Android:** Starts when the first activity to reach the foreground has its `onResume()` method called. <br><br>**iOS:** Starts when the application receives the `UIApplicationDidBecomeActiveNotification` notification.   | **Android:** Stops when the last activity to leave the foreground has its `onStop()` method called. <br><br>**iOS:** Stops when it receives the `UIApplicationWillResignActiveNotification` notification.     |
 | `_app_in_background`    | ✅ | Time when the app is running in the background.<br><br>**Platforms:** Android, iOS    | **Android:** Starts when the last activity to leave the foreground has its `onStop()` method called. <br><br>**iOS:** Starts when the application receives the `UIApplicationWillResignActiveNotification` notification.   | **Android:** Stops when the first activity to reach the foreground has its `onResume()` method called. <br><br>**iOS:** Stops when it receives the `UIApplicationDidBecomeActiveNotification` notification.     |
-| `sidebar_loaded`    | ❌ | Time taken for the Sidebar to load.<br><br>**Platforms:** All      | Starts when the Sidebar is mounted.     | Stops when the Splash Screen is hidden.     |
 | `calc_most_recent_last_modified_action`    | ✅ | Time taken to find the most recently modified report action or report.<br><br>**Platforms:** All      | Starts when the app reconnects to the network     | Ends when the app reconnects to the network and the most recent report action or report is found.     |
 | `search_render`   | ✅ | Time taken to render the Chat Finder page.<br><br>**Platforms:** All      | Starts when the Chat Finder icon in LHN is pressed.     | Stops when the list of available options is rendered for the first time.     |
 | `load_search_options`    | ✅ | Time taken to generate the list of options used in Chat Finder.<br><br>**Platforms:** All     | Starts when the `getSearchOptions` function is called.     | Stops when the list of available options is generated.     |
diff --git a/src/CONST.ts b/src/CONST.ts
@@ -1133,7 +1133,6 @@ const CONST = {
         SWITCH_REPORT: 'switch_report',
         OPEN_REPORT_FROM_PREVIEW: 'open_report_from_preview',
         OPEN_REPORT_THREAD: 'open_report_thread',
-        SIDEBAR_LOADED: 'sidebar_loaded',
         LOAD_SEARCH_OPTIONS: 'load_search_options',
         MESSAGE_SENT: 'message_sent',
         COLD: 'cold',
diff --git a/src/Expensify.tsx b/src/Expensify.tsx
@@ -138,7 +138,6 @@ function Expensify() {
 
     const onSplashHide = useCallback(() => {
         setSplashScreenState(CONST.BOOT_SPLASH_STATE.HIDDEN);
-        Performance.markEnd(CONST.TIMING.SIDEBAR_LOADED);
     }, [setSplashScreenState]);
 
     useLayoutEffect(() => {
diff --git a/src/libs/E2E/tests/chatOpeningTest.e2e.ts b/src/libs/E2E/tests/chatOpeningTest.e2e.ts
@@ -5,16 +5,13 @@ import waitForAppLoaded from '@libs/E2E/actions/waitForAppLoaded';
 import E2EClient from '@libs/E2E/client';
 import getConfigValueOrThrow from '@libs/E2E/utils/getConfigValueOrThrow';
 import getPromiseWithResolve from '@libs/E2E/utils/getPromiseWithResolve';
-import Navigation from '@libs/Navigation/Navigation';
 import Performance from '@libs/Performance';
 import CONST from '@src/CONST';
-import ROUTES from '@src/ROUTES';
 
 const test = (config: NativeConfig) => {
     // check for login (if already logged in the action will simply resolve)
     console.debug('[E2E] Logging in for chat opening');
 
-    const reportID = getConfigValueOrThrow('reportID', config);
     const name = getConfigValueOrThrow('name', config);
 
     E2ELogin().then((neededLogin) => {
@@ -37,13 +34,6 @@ const test = (config: NativeConfig) => {
         });
 
         Performance.subscribeToMeasurements((entry) => {
-            if (entry.name === CONST.TIMING.SIDEBAR_LOADED) {
-                console.debug(`[E2E] Sidebar loaded, navigating to report…`);
-                Performance.markStart(CONST.TIMING.OPEN_REPORT);
-                Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(reportID));
-                return;
-            }
-
             console.debug(`[E2E] Entry: ${JSON.stringify(entry)}`);
 
             if (entry.name === CONST.TIMING.OPEN_REPORT) {
diff --git a/src/libs/E2E/tests/linkingTest.e2e.ts b/src/libs/E2E/tests/linkingTest.e2e.ts
@@ -6,10 +6,8 @@ import waitForAppLoaded from '@libs/E2E/actions/waitForAppLoaded';
 import E2EClient from '@libs/E2E/client';
 import getConfigValueOrThrow from '@libs/E2E/utils/getConfigValueOrThrow';
 import getPromiseWithResolve from '@libs/E2E/utils/getPromiseWithResolve';
-import Navigation from '@libs/Navigation/Navigation';
 import Performance from '@libs/Performance';
 import CONST from '@src/CONST';
-import ROUTES from '@src/ROUTES';
 
 type ViewableItem = {
     reportActionID?: string;
@@ -20,7 +18,6 @@ type ViewableItemResponse = Array<{item?: ViewableItem}>;
 const test = (config: NativeConfig) => {
     console.debug('[E2E] Logging in for comment linking');
 
-    const reportID = getConfigValueOrThrow('reportID', config);
     const linkedReportActionID = getConfigValueOrThrow('linkedReportActionID', config);
     const name = getConfigValueOrThrow('name', config);
 
@@ -53,12 +50,6 @@ const test = (config: NativeConfig) => {
         });
 
         Performance.subscribeToMeasurements((entry) => {
-            if (entry.name === CONST.TIMING.SIDEBAR_LOADED) {
-                console.debug('[E2E] Sidebar loaded, navigating to a report…');
-                Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(reportID));
-                return;
-            }
-
             if (entry.name === CONST.TIMING.SWITCH_REPORT) {
                 console.debug('[E2E] Linking: 1');
 
diff --git a/src/libs/E2E/tests/openSearchRouterTest.e2e.ts b/src/libs/E2E/tests/openSearchRouterTest.e2e.ts
@@ -1,6 +1,5 @@
 import Config from 'react-native-config';
 import type {NativeConfig} from 'react-native-config';
-import * as E2EGenericPressableWrapper from '@components/Pressable/GenericPressable/index.e2e';
 import E2ELogin from '@libs/E2E/actions/e2eLogin';
 import waitForAppLoaded from '@libs/E2E/actions/waitForAppLoaded';
 import E2EClient from '@libs/E2E/client';
@@ -36,29 +35,6 @@ const test = (config: NativeConfig) => {
 
         Performance.subscribeToMeasurements((entry) => {
             console.debug(`[E2E] Entry: ${JSON.stringify(entry)}`);
-            if (entry.name === CONST.TIMING.SIDEBAR_LOADED) {
-                const props = E2EGenericPressableWrapper.getPressableProps('searchButton');
-                if (!props) {
-                    console.debug('[E2E] Search button not found, failing test!');
-                    E2EClient.submitTestResults({
-                        branch: Config.E2E_BRANCH,
-                        error: 'Search button not found',
-                        name: `${name} Open Search Router TTI`,
-                    }).then(() => E2EClient.submitTestDone());
-                    return;
-                }
-                if (!props.onPress) {
-                    console.debug('[E2E] Search button found but onPress prop was not present, failing test!');
-                    E2EClient.submitTestResults({
-                        branch: Config.E2E_BRANCH,
-                        error: 'Search button found but onPress prop was not present',
-                        name: `${name} Open Search Router TTI`,
-                    }).then(() => E2EClient.submitTestDone());
-                    return;
-                }
-                // Open the search router
-                props.onPress();
-            }
 
             if (entry.name === CONST.TIMING.SEARCH_ROUTER_RENDER) {
                 E2EClient.submitTestResults({
diff --git a/src/libs/E2E/tests/reportTypingTest.e2e.ts b/src/libs/E2E/tests/reportTypingTest.e2e.ts
@@ -53,10 +53,6 @@ const test = (config: NativeConfig) => {
                 return;
             }
 
-            if (entry.name !== CONST.TIMING.SIDEBAR_LOADED) {
-                return;
-            }
-
             console.debug(`[E2E] Sidebar loaded, navigating to a report…`);
             // Crowded Policy (Do Not Delete) Report, has a input bar available:
             Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(reportID));
diff --git a/src/libs/Performance.tsx b/src/libs/Performance.tsx
@@ -160,10 +160,6 @@ if (Metrics.canCapturePerformanceMetrics()) {
                 }
 
                 // Capture any custom measures or metrics below
-                if (mark.name === `${CONST.TIMING.SIDEBAR_LOADED}_end`) {
-                    Performance.measureFailSafe('contentAppeared_To_screenTTI', 'contentAppeared', mark.name);
-                    Performance.measureTTI(mark.name);
-                }
             });
         }).observe({type: 'mark', buffered: true});
     };
diff --git a/src/pages/home/sidebar/SidebarScreen/BaseSidebarScreen.tsx b/src/pages/home/sidebar/SidebarScreen/BaseSidebarScreen.tsx
@@ -31,11 +31,6 @@ function BaseSidebarScreen() {
     const {shouldUseNarrowLayout} = useResponsiveLayout();
     const [activeWorkspace] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${activeWorkspaceID ?? -1}`);
 
-    useEffect(() => {
-        Performance.markStart(CONST.TIMING.SIDEBAR_LOADED);
-        Timing.start(CONST.TIMING.SIDEBAR_LOADED);
-    }, []);
-
     useEffect(() => {
         if (!!activeWorkspace || activeWorkspaceID === undefined) {
             return;
