WIP: bag of commits from the boat - POP

Author: jmoody

Guardfile

@@ -13,7 +13,7 @@ end
 guard :rspec, cmd: 'bundle exec rspec', spec_paths: ['spec/lib'] do
   watch(%r{^spec/.+_spec\.rb$})
   watch(%r{^lib/run_loop/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
-  watch(%r{^lib/run_loop/bin/(.+)\.rb$})     { |m| "spec/lib/bin/#{m[1]}_spec.rb" }
+  #watch(%r{^lib/run_loop/bin/(.+)\.rb$})     { |m| "spec/lib/bin/#{m[1]}_spec.rb" }
   watch('lib/run_loop.rb')  { 'spec/lib' }
   watch('spec/spec_helper.rb')  { 'spec/lib' }
   watch('spec/resources.rb')  { 'spec/lib' }

lib/run_loop/cli/simctl.rb

@@ -133,7 +133,7 @@ def install
         def expect_device(options)
           device = nil
           device_from_options = options[:device]
-          simulators = RunLoop::SimControl.new.simulators
+          simulators = sim_control.simulators
           if device_from_options.nil?
             default_name = RunLoop::Core.default_simulator
             device = simulators.detect do |sim|

lib/run_loop/simctl/bridge.rb

@@ -131,6 +131,10 @@ def reset_app_sandbox
       reset_app_sandbox_internal
     end
 
+    def install_uia_plists
+
+    end
+
     def update_device_state(options={})
       merged_options = UPDATE_DEVICE_STATE_OPTS.merge(options)
 
@@ -233,6 +237,15 @@ def app_is_installed?
       !fetch_app_dir.nil?
     end
 
+    # @!visibility private
+    def fetch_app_dir
+      sim_app_dir = device_applications_dir
+      return nil if !File.exist?(sim_app_dir)
+      Dir.glob("#{sim_app_dir}/**/*.app").detect(nil) do |path|
+        RunLoop::App.new(path).bundle_identifier == app.bundle_identifier
+      end
+    end
+
     def wait_for_app_install
       return true if app_is_installed?
 
@@ -424,15 +437,6 @@ def fetch_matching_device
       end
     end
 
-    # @!visibility private
-    def fetch_app_dir
-      sim_app_dir = device_applications_dir
-      return nil if !File.exist?(sim_app_dir)
-      Dir.glob("#{sim_app_dir}/**/*.app").detect(nil) do |path|
-        RunLoop::App.new(path).bundle_identifier == app.bundle_identifier
-      end
-    end
-
     # @!visibility private
     def reset_app_sandbox_internal_shared
       [app_documents_dir, app_tmp_dir].each do |dir|
@@ -498,5 +502,20 @@ def reset_app_sandbox_internal
         reset_app_sandbox_internal_sdk_lt_8
       end
     end
+
+    # @!visibility private
+    def app_uia_crash_logs
+      base_dir = app_data_dir
+      if base_dir.nil?
+        nil
+      else
+        dir = File.join(base_dir, 'Library', 'CrashReporter', 'UIALogs')
+        if Dir.exist?(dir)
+          Dir.glob("#{dir}/*.plist")
+        else
+          nil
+        end
+      end
+    end
   end
 end

spec/lib/cli/simctl_spec.rb

@@ -19,4 +19,43 @@
       expect(simctl.booted_device).to be == device
     end
   end
+
+  describe '#expect_device' do
+    describe 'default simulator' do
+      it 'raises error if device cannot be created from default simulator' do
+        expect(simctl.sim_control).to receive(:simulators).and_return([])
+        expect {
+          simctl.expect_device({})
+        }.to raise_error RunLoop::CLI::ValidationError
+
+      end
+
+      it 'can create a device from default simulator' do
+        expect(simctl.expect_device({})).to be_a_kind_of( RunLoop::Device)
+      end
+    end
+
+    describe 'when passed a UDID or instruments-ready simulator name' do
+      let(:device) {
+        Resources.shared.simulator_with_sdk_test(lambda { |_|
+                                                   true
+                                                 },
+                                                 simctl.sim_control)
+      }
+
+      it 'UUID' do
+        options = { :device => device.udid }
+        expect(simctl.expect_device(options).udid).to be == device.udid
+      end
+
+      it 'name' do
+
+      end
+
+      it 'raises error error if no match can be found' do
+
+      end
+
+    end
+  end
 end