Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configuration property to control max number of studies in study view page #10125

Closed
2 tasks done
alisman opened this issue Apr 12, 2023 · 2 comments · Fixed by #10128 or cBioPortal/cbioportal-frontend#4587
Closed
2 tasks done
Assignees

Comments

@alisman
Copy link
Contributor

alisman commented Apr 12, 2023

This is enforced only on query page.

It disables the Explore button when more than the limit is reached:

image

The current limit of 50 is hardcoded in studyLimitedReached method of QueryContainer. We need to link this up with configuration and backend configuration.

@pvannierop
Copy link
Contributor

pvannierop commented Apr 17, 2023

@alisman @haynescd Would it be possible to (optionally) limit based on the number of samples/patients that are selected? Or perhaps limit based on the number of studies AND the number of samples? We get this question from clients. The reason for this is poor performce of Study View when selecting too large sample numbers.

@haynescd
Copy link
Collaborator

@pvannierop Sounds good. Will incorporate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants