Skip to content

Commit 9b5b740

Browse files
author
Bas Leenknegt
committed
Expect submit button only when filter queued in autosubmit toggle e2e tests
1 parent 5d8d336 commit 9b5b740

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

end-to-end-test/local/specs/study-view-filters-autocommit-toggle.spec.js

+11-6
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ const SELECT_SAMPLES_BUTTON = 'button=Select Samples';
99
const ADD_FILTERS_BUTTON = 'button=Add Filters';
1010
const STUDY_VIEW_HEADER = `div[data-test="study-view-header"]`;
1111
const SETTINGS_MENU_BUTTON = `button[data-test="study-view-settings-menu"]`;
12-
const DISABLE_AUTOCOMMIT_FIELD = `label=Manually submit`;
12+
const MANUALLY_COMMIT_RADIO = `input[name="hesitateMode"][value="manual"]`;
13+
const AUTOCOMMIT_RADIO = `input[name="hesitateMode"][value="auto"]`;
1314
const SUBMIT_STUDY_FILTERS = `button[data-test="submit-study-filters"]`;
1415
const PUTATIVE_PROFILE =
1516
"//span[text() = 'Putative copy-number alterations from GISTIC']";
@@ -30,13 +31,16 @@ describe.only('Toggling of study view filters autosubmit', function() {
3031
assert(!isFilterQueued);
3132
});
3233

33-
it('can disable filter submission in settings menu', () => {
34-
$(SETTINGS_MENU_BUTTON).waitForDisplayed({ timeout: 20000 });
34+
it('can toggle to manual submit in settings menu', () => {
35+
$(SETTINGS_MENU_BUTTON).waitForDisplayed({ timeout: 5000 });
3536
$(SETTINGS_MENU_BUTTON).click();
36-
$(DISABLE_AUTOCOMMIT_FIELD).waitForDisplayed({ timeout: 20000 });
37-
$(DISABLE_AUTOCOMMIT_FIELD).click();
37+
$(AUTOCOMMIT_RADIO).waitForDisplayed({ timeout: 5000 });
38+
assert($(AUTOCOMMIT_RADIO).isSelected());
3839

39-
assert($(SUBMIT_STUDY_FILTERS).isDisplayed());
40+
$(MANUALLY_COMMIT_RADIO).click();
41+
42+
assert($(MANUALLY_COMMIT_RADIO).isSelected());
43+
assert(!$(AUTOCOMMIT_RADIO).isSelected());
4044
});
4145

4246
it('queues new filters when autosubmit disabled', () => {
@@ -45,6 +49,7 @@ describe.only('Toggling of study view filters autosubmit', function() {
4549

4650
const queuedFilterInHeader = $(STUDY_VIEW_HEADER).$(LOG2_PROFILE);
4751
assert(queuedFilterInHeader.isDisplayed());
52+
assert($(SUBMIT_STUDY_FILTERS).isDisplayed());
4853
const isFilterQueued = hasFilterClass(queuedFilterInHeader, 'pending');
4954
assert(isFilterQueued);
5055
});

0 commit comments

Comments
 (0)