add "Files & Links" tab with review changes

Author: Nelliney

src/pages/studyView/resources/FilesAndLinks.tsx

@@ -24,7 +24,7 @@ export interface IFilesLinksTable {
 }
 
 class FilesLinksTableComponent extends LazyMobXTable<{
-    [id: string]: string;
+    [id: string]: string | number;
 }> {}
 
 const RECORD_LIMIT = 500;
@@ -70,20 +70,24 @@ async function fetchFilesLinksData(
         0
     );
 
+    // get unique patient Ids from clinical data to get their resources
+    // via fetchResourceDataOfPatient.
     const patientIds = new Map<string, string>();
-    _.forEach(sampleClinicalDataResponse.data, (data, uniqueSampleId) => {
+    _.forEach(sampleClinicalDataResponse.data, data => {
         _.forEach(data, item => {
             patientIds.set(item.patientId, item.studyId);
         });
     });
 
+    // get all resources for patients.
+    // improvement: use one request for getting a page of patients
+    // with their samples and resources.
     const resourcesForPatients = await fetchResourceDataOfPatient(patientIds);
-
     const buildItemsAndResources = (resourceData: {
         [key: string]: ResourceData[];
     }) => {
         const resourcesPerPatient: { [key: string]: number } = {};
-        const items: { [attributeId: string]: any } = [];
+        const items: { [attributeId: string]: string | number }[] = [];
         _.forEach(resourceData, (data: ResourceData[]) => {
             _.forEach(data, (resource: ResourceData) => {
                 items.push({
@@ -94,7 +98,7 @@ async function fetchFilesLinksData(
                     typeOfResource: resource?.resourceDefinition?.displayName,
                     description: resource?.resourceDefinition?.description,
                     url: resource?.url,
-                });
+                } as { [attributeId: string]: string | number });
             });
 
             if (data && data.length > 0) {
@@ -108,23 +112,25 @@ async function fetchFilesLinksData(
         return { resourcesPerPatient, items };
     };
 
-    const resourcesForPatientsAndSamples = {
+    const resourcesForPatientsAndSamples: { [key: string]: ResourceData[] } = {
         ...sampleIdResourceData,
         ...resourcesForPatients,
     };
 
-    //we create objects with the necessary properties for each resource
-    //calculate the total number of resources per patient.
-
+    // we create objects with the necessary properties for each resource
+    // calculate the total number of resources per patient.
     const { resourcesPerPatient, items } = buildItemsAndResources(
         resourcesForPatientsAndSamples
     );
-    const data = _.mapValues(items, item => {
+
+    // set the number of resources available per patient.
+    _.forEach(items, item => {
         item.resourcesPerPatient = resourcesPerPatient[item.patientId];
-        return item;
     });
 
-    const sortedData = _.orderBy(data, 'resourcesPerPatient', 'desc');
+    // there is a requirement to sort initially by 'resourcesPerPatient' field
+    // in descending order.
+    const sortedData = _.orderBy(items, 'resourcesPerPatient', 'desc');
     return {
         totalItems: sortedData.length,
         data: _.values(sortedData),
@@ -161,11 +167,7 @@ export class FilesAndLinks extends React.Component<IFilesLinksTable, {}> {
             download: (data: { [id: string]: string }) => data[key] || '',
             sortBy: (data: { [id: string]: any }) => {
                 if (data[key]) {
-                    if (isNumber) {
-                        return parseFloat(data[key]);
-                    } else {
-                        return data[key];
-                    }
+                    return data[key];
                 }
                 return null;
             },
@@ -232,6 +234,7 @@ export class FilesAndLinks extends React.Component<IFilesLinksTable, {}> {
                     );
                 },
             },
+
             {
                 ...this.getDefaultColumnConfig('sampleId', 'Sample ID'),
                 render: (data: { [id: string]: string }) => {