Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 2 - "Deploy a Single Server" needs updating now that EC2 classic is retired. #86

Closed
jeremy-cxf opened this issue Sep 6, 2022 · 3 comments
Labels

Comments

@jeremy-cxf
Copy link

jeremy-cxf commented Sep 6, 2022

Heya,

Love the book so far.

Micro issue. The chapter 2 the code will no longer work given that EC2 Classic is retired, thus users now need to either reference an existing VPC or go over creating a new one.

Perhaps this might get daunting for those who haven't approached VPC concepts, however, I've noticed the network security bit does go over this at a high level.

I'm sure you're already aware of it, but perhaps acknowledging this on the repo with a bit of a simple edit (referencing the default VPC) can suffice :)

Thanks!

@brikis98 brikis98 added the bug label Sep 6, 2022
@brikis98
Copy link
Owner

brikis98 commented Sep 6, 2022

Thanks for the heads up. I think this broke 5 days ago when version 4.29.0 of the AWS provider came out. As it turns out, that version has major breaking changes in it, even though it's only marked as a minor release. I've pinged the AWS provider folks in hashicorp/terraform-provider-aws#23625 to see if there is some way to avoid this huge breaking change.

@brikis98
Copy link
Owner

brikis98 commented Sep 9, 2022

Update: as per this comment, this issue has been fixed in 4.30.0 of the AWS provider! So, all the examples should work as-written, just as long as you avoid the buggy 4.29.0 version.

@brikis98 brikis98 closed this as completed Sep 9, 2022
@jeremy-cxf
Copy link
Author

👏 yeww. tested and confirmed working :) thanks for nudging them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants