Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Patch mime sniffer for html utf8 bom, svg and xml files OS-16547 #37

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

t-bashir-bs
Copy link

Description of Change

This change cherry picks change IDs from QtWebEngine.

  • I11c9915a4c23155fc8b8b4e405b69ed48821db5a
  • I7ee3558529c24a08b22b1ad3a4a9d6df73174cdd
  • I6d9a40bb65b8ff4d44e4e5b6d850f1a728768feb

These patch the mime sniffer to allow it to handle html files with utf8 bom, recognise svg files and allow for comments in xml files.
It includes an additional change not in the QtWebEngine version to stop the binary sniffer changing the mime type of text/xml files to text/plain.
Change includes new test cases.

Checklist

Release Notes

Notes:

@caneraltinbasak
Copy link

Is this ready, or would you like to have your CSS sniff fix in this changeset?

@t-bashir-bs
Copy link
Author

Is this ready, or would you like to have your CSS sniff fix in this changeset?

Its ready. The CSS issue (when I finally find the cause) will likely will mean patching some other file and I think is different enough to be in a different changeset.

@t-bashir-bs t-bashir-bs merged commit 9a39462 into 23-x-y-bs Jan 15, 2024
6 checks passed
t-bashir-bs added a commit that referenced this pull request Apr 24, 2024
…#37)

* fix: mime sniffer handle html utf8 bom, svg files and xml comments OS-16547

* fix: stop binary sniffer overriding mime type for xml files

Cherry picked from:
9a39462: fix: Patch mime sniffer for html utf8 bom, svg and xml files OS-16547 (#37)
t-bashir-bs added a commit that referenced this pull request Apr 25, 2024
…#37)

* fix: mime sniffer handle html utf8 bom, svg files and xml comments OS-16547

* fix: stop binary sniffer overriding mime type for xml files

Cherry picked from:
9a39462: fix: Patch mime sniffer for html utf8 bom, svg and xml files OS-16547 (#37)
t-bashir-bs added a commit that referenced this pull request Apr 26, 2024
…#37)

* fix: mime sniffer handle html utf8 bom, svg files and xml comments OS-16547

* fix: stop binary sniffer overriding mime type for xml files

Cherry picked from:
9a39462: fix: Patch mime sniffer for html utf8 bom, svg and xml files OS-16547 (#37)
t-bashir-bs added a commit that referenced this pull request Apr 26, 2024
…#37)

* fix: mime sniffer handle html utf8 bom, svg files and xml comments OS-16547

* fix: stop binary sniffer overriding mime type for xml files

Cherry picked from:
9a39462: fix: Patch mime sniffer for html utf8 bom, svg and xml files OS-16547 (#37)
t-bashir-bs added a commit that referenced this pull request Apr 26, 2024
…#37)

* fix: mime sniffer handle html utf8 bom, svg files and xml comments OS-16547

* fix: stop binary sniffer overriding mime type for xml files

Cherry picked from:
9a39462: fix: Patch mime sniffer for html utf8 bom, svg and xml files OS-16547 (#37)
t-bashir-bs added a commit that referenced this pull request Apr 26, 2024
…#37)

* fix: mime sniffer handle html utf8 bom, svg files and xml comments OS-16547

* fix: stop binary sniffer overriding mime type for xml files

Cherry picked from:
9a39462: fix: Patch mime sniffer for html utf8 bom, svg and xml files OS-16547 (#37)
t-bashir-bs added a commit that referenced this pull request Apr 26, 2024
…#37)

* fix: mime sniffer handle html utf8 bom, svg files and xml comments OS-16547

* fix: stop binary sniffer overriding mime type for xml files

Cherry picked from:
9a39462: fix: Patch mime sniffer for html utf8 bom, svg and xml files OS-16547 (#37)
t-bashir-bs added a commit that referenced this pull request Apr 29, 2024
…#37)

* fix: mime sniffer handle html utf8 bom, svg files and xml comments OS-16547

* fix: stop binary sniffer overriding mime type for xml files

Cherry picked from:
9a39462: fix: Patch mime sniffer for html utf8 bom, svg and xml files OS-16547 (#37)
caneraltinbasak pushed a commit that referenced this pull request Apr 30, 2024
…#37)

* fix: mime sniffer handle html utf8 bom, svg files and xml comments OS-16547

* fix: stop binary sniffer overriding mime type for xml files

Cherry picked from:
9a39462: fix: Patch mime sniffer for html utf8 bom, svg and xml files OS-16547 (#37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants