EC Suite B: Remove redundant "point_mul" tests. #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I generated these test vectors, I gave all of them the same point: the generator of the curve. Consequently these input files are 100% redundant with the `point_mul_base.txt` input files. So just remove them and use the `point_mul_base.txt` files instead.
|
@vkrasnov This is the first step towards checking in the (new) generator for the curve arithmetic test generator. |
Codecov Report
@@ Coverage Diff @@
## main #1769 +/- ##
==========================================
+ Coverage 96.00% 96.01% +0.01%
==========================================
Files 138 138
Lines 20754 20788 +34
Branches 226 226
==========================================
+ Hits 19924 19959 +35
+ Misses 792 790 -2
- Partials 38 39 +1
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
briansmith
changed the title
This was referenced Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I generated these test vectors, I gave all of them the same point: the generator of the curve. Consequently these input files are 100% redundant with the
point_mul_base.txtinput files. So just remove them and use thepoint_mul_base.txtfiles instead.