[bug] Fix Tmux Config Parsing #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompiler changes. 1.4.5 was reported to work for people on Github so that's what I went with
I was getting this error ``` thread 'main' panicked at 'index out of bounds: the len is 1 but the index is 1', load/src/tmux/config.rs:25:35 ``` From looking at the options tmux is printing on my machine I found the issue was with the `pane-colours` option. Which didn't have a value in my TMUX. This is while running a potentially pre-release version from Homebrew Just making it so we get an empty string if there is no value at least gets around the panic. Assuming `muxed` doesn't rely on `pane-colours` it _feels_ like it might be a reasonable move. We could also not write `pane-colours` at all if it doesn't have a value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey again! I've made a few changes in my fork, and wanted to contribute them back! The first one here is a bug fix I ran into with newer versions of tmux
I was running into issues with parsing the my tmux config after a tmux upgrade. Unfortunately I didn't record the version I was upgrading too, for documentation
What I found when digging in was that tmux was reporting a config option that did not have a value. This was breaking the config parsing in
muxed.Since muxed only actually checks for a few config options, and not the value less ones I was finding. The easiest fix seemed to be to default to an empty string value in this case, which this PR implements!