From d1debfcbfc3b6c217edb30ccf656e76fe9bfe5ac Mon Sep 17 00:00:00 2001
From: Michael Mikonos <127171689+mknos@users.noreply.github.com>
Date: Wed, 19 Feb 2025 09:18:47 +0800
Subject: [PATCH] moo: raise error for size>10

* The maximum number of distinct digits is 10
* This version didn't raise an error for larger values of size parameter
* Based on commit f3248c817c65b13363fbc27f5c10c11b7201475e in bin/fish, add entropy thanks to hash keys being "unordered"
---
 bin/moo | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/bin/moo b/bin/moo
index 307a75aa..078dfd80 100755
--- a/bin/moo
+++ b/bin/moo
@@ -15,12 +15,22 @@ use strict;
 
 use List::Util qw(shuffle);
 
-my ($VERSION) = '1.3';
+my ($VERSION) = '1.4';
 
 sub usage {
     die "usage: moo [size]\n";
 }
 
+sub get_secret {
+    my $size = shift;
+
+    my $i = $size - 1;
+    my %digits = map { $_ => 1 } (0 .. 9);
+    my @s1 = keys %digits;
+    my @s2 = shuffle(@s1);
+    return @s2[0 .. $i];
+}
+
 sub has_dupe {
     my $guess = shift;
     my %chars;
@@ -34,12 +44,12 @@ sub has_dupe {
 my $size = shift;
 $size = 4 unless defined $size;
 usage() if $size !~ m/\A[0-9]+\Z/ or !$size;
+die "secret size must be within range: 1-10\n" if $size > 10;
 usage() if @ARGV;
 
 print "MOO\n";
 {
-    my @secret = shuffle(0 .. 9);
-    @secret = splice @secret, 0, $size;
+    my @secret = get_secret($size);
     my @secret_by_value = (0) x 10;
     foreach my $i (@secret) {
         $secret_by_value[$i] = 1;