From 0a4fb31929383d7825a85f54650019a5e768478d Mon Sep 17 00:00:00 2001
From: Michael Mikonos <127171689+mknos@users.noreply.github.com>
Date: Fri, 29 Dec 2023 19:00:29 +0800
Subject: [PATCH] fortune: fail for bad options

* Print usage and exit if an unknown option was entered, following OpenBSD version[1]
* -h is not really an option
* Mention -n option in usage string as done in SYNOPSIS
* Document the purpose of -d flag in usage string and pod

1. https://github.com/openbsd/src/blob/master/games/fortune/fortune/fortune.c#L304
---
 bin/fortune | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/bin/fortune b/bin/fortune
index 160dcc3c..3f65272c 100755
--- a/bin/fortune
+++ b/bin/fortune
@@ -42,7 +42,7 @@ my $STR_ROTATED = 0x4;
 # Globals
 my (%opts);
 
-getopts('adefhilosvwm:n:', \%opts);
+getopts('adefilosvwm:n:', \%opts) or print_help();
 
 my $debug = $opts{d};
 
@@ -75,8 +75,6 @@ my %Top_item = ( name => 'Top level file/directory list',
 
 # this is the main routine of the program
 
-if ($opts{h}) { print_help(); }
-
 build_file_list( list_files( \%Top_item ) );
 
 if ($opts{m}) {
@@ -956,11 +954,12 @@ sub print_help
 
 	print <<EOF;
 
-Usage: $0 [-adefhilosw] [-m pattern] [[N%] file/dir/all]
+Usage: $0 [-adefilosw] [-n length] [-m pattern] [[N%] file/dir/all]
 
 	See the POD for more information.
 
      -a Choose from all lists of maxims, both offensive and not.
+     -d Enable debug messages
      -e Consider all fortune files to be of equal size.
      -f Print out the list of files which would be searched.
      -l Long dictums only.
@@ -983,8 +982,6 @@ EOF
 	exit 1;
 }
 
-1;
-
 __END__
 
 =pod
@@ -1007,6 +1004,8 @@ not.  The options are as follows:
      -a    Choose from all lists of maxims, both offensive and not.  (See the
            -o option for more information on offensive fortunes.)
 
+     -d    Enable debug messages.
+
      -e    Consider all fortune files to be of equal size (see discussion be-
            low on multiple files).