id: gid 0 is valid (#715)

mknos · web-flow · commit 4ef9c6da5e74 · 2024-08-12T07:11:46.000-04:00
* Previously commit 92678da was added to allow resolving "root" to uid 0 * When testing -g option a similar issue was discovered (gid of 0 was being treated as a failure of getpwnam) * This was discovered while testing against id on my Linux system %grep '^root' /etc/group root:x:0: %/usr/bin/id -g root 0 %perl id -g root # before patch 1000
diff --git a/bin/id b/bin/id
@@ -45,7 +45,7 @@ if ( $opt_u ) { # print uid
 	$tp = scalar getpwuid $tp || $tp if ( $opt_n );
 }
 elsif ( $opt_g ) { # print gid
-	$tp = ($gid)?$gid:(split(/\s+/,($opt_r)?$(:$)))[0];
+	$tp = defined $gid ? $gid : (split(/\s+/,($opt_r)?$(:$)))[0];
 	$tp = scalar getgrgid $tp || $tp if ( $opt_n );
 }
 elsif ( $opt_p ) { # human-readable form (names when possible, etc.)

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ if ( $opt_u ) { # print uid`
`45`	`45`	`$tp = scalar getpwuid $tp \|\| $tp if ( $opt_n );`
`46`	`46`	`}`
`47`	`47`	`elsif ( $opt_g ) { # print gid`
`48`		`- $tp = ($gid)?$gid:(split(/\s+/,($opt_r)?$(:$)))[0];`
	`48`	`+ $tp = defined $gid ? $gid : (split(/\s+/,($opt_r)?$(:$)))[0];`
`49`	`49`	`$tp = scalar getgrgid $tp \|\| $tp if ( $opt_n );`
`50`	`50`	`}`
`51`	`51`	`elsif ( $opt_p ) { # human-readable form (names when possible, etc.)`