Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the mode change has worked correctly #13

Closed
breakintoprogram opened this issue Feb 12, 2023 · 1 comment
Closed

Check the mode change has worked correctly #13

breakintoprogram opened this issue Feb 12, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@breakintoprogram
Copy link
Owner

breakintoprogram commented Feb 12, 2023 •
edited
Loading

When changing video mode in the VDP, check that the display height is the same as the viewport or canvas height. If they are not (viewport or canvas height < display height) then the mode has not been set correctly due to lack of memory on the ESP32. Throw an error and revert back to original mode.
@breakintoprogram breakintoprogram converted this from a draft issue Feb 12, 2023
@breakintoprogram breakintoprogram added the enhancement New feature or request label Feb 12, 2023
@breakintoprogram breakintoprogram moved this to In Progress in AGON Quark Firmware Mar 17, 2023
@breakintoprogram breakintoprogram moved this from In Progress to QA in AGON Quark Firmware Mar 17, 2023
@breakintoprogram
Copy link
Owner Author

Checks the VGAController height against the viewPortHeight. If there is a difference, then restore the last known mode.

@breakintoprogram breakintoprogram moved this from QA to Done in AGON Quark Firmware Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
AGON Quark Firmware
Status: Released
Milestone
No milestone
Development

No branches or pull requests
1 participant
@breakintoprogram