Fix renderer IPC failing

bbondy · bbondy · commit f46584a8a988 · 2016-12-12T00:59:06.000-05:00
This is failing a bunch of automated tests and general functionality. Bug was introduced here: 96b2f08#diff-6d7213223d17eee94ce8a64e16ead954L29 The assignment was shortcircuited with `arguments[1] &&` before. Fix brave/browser-laptop#6151 Auditors: @bridiver
diff --git a/atom/common/api/resources/ipc_utils.js b/atom/common/api/resources/ipc_utils.js
@@ -25,7 +25,9 @@ if (!ipcRenderer) {
   }
 
   ipcRenderer.emit = function () {
-    arguments[1].sender = ipcRenderer
+    if (arguments[1]) {
+      arguments[1].sender = ipcRenderer
+    }
     return $Function.apply(EventEmitter.prototype.emit, ipcRenderer, arguments)
   }
   atom.v8.setHiddenValue('ipc', ipcRenderer)

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,9 @@ if (!ipcRenderer) {`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`ipcRenderer.emit = function () {`
`28`		`- arguments[1].sender = ipcRenderer`
	`28`	`+ if (arguments[1]) {`
	`29`	`+ arguments[1].sender = ipcRenderer`
	`30`	`+ }`
`29`	`31`	`return $Function.apply(EventEmitter.prototype.emit, ipcRenderer, arguments)`
`30`	`32`	`}`
`31`	`33`	`atom.v8.setHiddenValue('ipc', ipcRenderer)`