Merge pull request #358 from brave/fix/private-session-tabs

bridiver · web-flow · commit 0aa85d048378 · 2017-10-24T18:49:11.000-07:00
Set parent_partition to '' for private session tabs
diff --git a/brave/browser/guest_view/tab_view/tab_view_guest.cc b/brave/browser/guest_view/tab_view/tab_view_guest.cc
@@ -254,8 +254,11 @@ void TabViewGuest::CreateWebContents(
     partition_options.SetString("parent_partition", parent_partition);
   } else {
     std::string session_tab_prefix = "persist:partition-";
+    std::string private_tab_prefix = "partition-";
     if (partition.compare(0, session_tab_prefix.length(),
-          session_tab_prefix) == 0) {
+          session_tab_prefix) == 0 ||
+       partition.compare(0, private_tab_prefix.length(),
+          private_tab_prefix) == 0) {
       partition_options.SetString("parent_partition", "");
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -254,8 +254,11 @@ void TabViewGuest::CreateWebContents(`
`254`	`254`	`partition_options.SetString("parent_partition", parent_partition);`
`255`	`255`	`} else {`
`256`	`256`	`std::string session_tab_prefix = "persist:partition-";`
	`257`	`+ std::string private_tab_prefix = "partition-";`
`257`	`258`	`if (partition.compare(0, session_tab_prefix.length(),`
`258`		`- session_tab_prefix) == 0) {`
	`259`	`+ session_tab_prefix) == 0 \|\|`
	`260`	`+ partition.compare(0, private_tab_prefix.length(),`
	`261`	`+ private_tab_prefix) == 0) {`
`259`	`262`	`partition_options.SetString("parent_partition", "");`
`260`	`263`	`}`
`261`	`264`	`}`