Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Add welcome.properties for about:welcome localization #9521

Closed
luixxiul opened this issue Jun 16, 2017 · 3 comments
Closed

Add welcome.properties for about:welcome localization #9521

luixxiul opened this issue Jun 16, 2017 · 3 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jun 16, 2017

Describe the issue you encountered: Add welcome.properties for about:welcome localization.

@luixxiul luixxiul added this to the 0.18.x (Developer Channel) milestone Jun 16, 2017
@bsclifton bsclifton removed this from the 0.18.x (Developer Channel) milestone Jun 16, 2017
@bsclifton
Copy link
Member

bsclifton commented Jun 16, 2017

The welcome page itself is part of https://github.com/brave/brave-website which should allow for localization 😄

@eljuno
Copy link
Contributor

eljuno commented Jul 29, 2017

Since the page is already live, maybe make an announcement on Transifex to increase localizer awareness?
I'm sure not everyone know that the strings for about:welcome is on brave-website project not brave-laptop project. And the early translation is done by vendor.

Personally, I still thinking it'll better to have it as welcome.properties on brave-laptop than separate project. Since it's a feature in browser itself. 😄

Or maybe no need to localized this? Since first time users will have Brave in English (no option to change language when first install).

@luixxiul
Copy link
Contributor Author

Since first time users will have Brave in English (no option to change language when first install).

FYI that issue is tracked on #6435

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants