Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

After dismissing the "Support your favorite sites" banner, focus is not returned to the active tab's content area #8742

Closed
bsclifton opened this issue May 7, 2017 · 8 comments
Labels
accessibility addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. wontfix

Comments

@bsclifton
Copy link
Member

This is likely a more broad issue (ex: affecting all notifications and the accepting of their options).

But issue as reported:
Being presented with the "Are you ready to support your favorite sites". You choose "no" and focus isn't sent back to the active tab's content area

@bsclifton bsclifton added the bug label May 7, 2017
@bsclifton
Copy link
Member Author

bsclifton commented May 7, 2017

similar #7666

@bsclifton bsclifton added this to the 1.1.0 milestone May 7, 2017
@kumarrishav kumarrishav self-assigned this May 17, 2017
@alexwykoff alexwykoff modified the milestones: 1.1.0, Backlog Nov 1, 2017
@NejcZdovc NejcZdovc added the help wanted The PR/issue opener needs help to complete/report the task. label May 7, 2018
@dcrck
Copy link

dcrck commented Aug 29, 2018

This behavior is still present in v0.23.104 on MacOS. My test is opening a window, running alert() from the console, dismissing the popup, then trying to scroll by pressing the arrow keys. This doesn't work until I click on the window again.

I can take a look in more detail tomorrow.

@dcrck
Copy link

dcrck commented Aug 29, 2018

Strange...whenever a banner like "Allow Google to access your location" pops up, I see the following warnings in the console:
Aug 29 00:49:03 Brave Helper[18597] : CGSConnectionByID: 0 is not a valid connection ID.
Aug 29 00:49:03 Brave Helper[18597] : Invalid Connection ID 0

I think this is macOS-exclusive, but perhaps something to keep in mind.

@dcrck
Copy link

dcrck commented Aug 30, 2018

@bsclifton Is there an existing function to return the focus to the active tab's content area? I found windowActions.setFocusedFrame, but that doesn't seem to work for this case.

@petemill
Copy link
Member

@rederekt webviewActions.setWebviewFocused()

@dcrck
Copy link

dcrck commented Aug 30, 2018

Thanks @petemill ! That's one of the few I hadn't tried 😅

Should have a PR fix submitted soon

@dcrck
Copy link

dcrck commented Aug 30, 2018

PR submitted (#15130) 😄

@bsclifton bsclifton removed bug/good-first-bug help wanted The PR/issue opener needs help to complete/report the task. labels Sep 1, 2018
@bsclifton bsclifton added wontfix addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. labels Sep 21, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 21, 2018
@bsclifton
Copy link
Member Author

Closing as we move to a new code-base (where Brave Payments is being reworked and will now be known as Brave Rewards)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. wontfix
Projects
None yet
Development

No branches or pull requests

6 participants