Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

"Lookup" text in input on macOS is intermittently failing #7043

Closed
bbondy opened this issue Feb 3, 2017 · 3 comments
Closed

"Lookup" text in input on macOS is intermittently failing #7043

bbondy opened this issue Feb 3, 2017 · 3 comments

Comments

@bbondy
Copy link
Member

bbondy commented Feb 3, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    While testing Selected text in text fields is missing Look Up in context menu (macOS-only) #6536 I noticed that about half the time text isn't appearing when I do a lookup.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    0.13.2-rc3

  • Steps to reproduce:
    Scenario A:

    1. Go to digg.com
    2. Type dig in the search box in the page content
    3. Select Lookup "dig" from the right click context menu
      Scenario B:
    4. Go to google.com
    5. Type hello in the search box
    6. Select Lookup "hello" from the right click context menu
  • Actual result:
    In scenario A, intermittently the lookup window will come up but with no text.
    In scenario B, intermittently nothing will happen

  • Expected result:
    I expect the lookup window to show up in both cases

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes, I believe so.

  • Is this an issue in the currently released version?
    Not yet but we're in RC testing.

  • Can this issue be consistently reproduced?
    Not consistently, I've seen it work but most of the time it is failing for me.

  • Screenshot if needed:
    Scenario A:

screenshot 2017-02-03 16 26 44

  • Any related issues:
@cndouglas
Copy link

I've tried several different sites, but I am not able to reproduce with Brave 0.13.2 RC 3 on macOS 10.12.x.

Clicking Look Up should never open the Dictionary app directly. Normally, it shows the popover as seen below.

Scenario 2:

@luixxiul luixxiul added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Feb 4, 2017
@bbondy
Copy link
Member Author

bbondy commented Feb 4, 2017

wow that's strange, I am getting that now as well so I'm not sure how it was opening up the app. But things were definitely intermittent.

@bbondy
Copy link
Member Author

bbondy commented Feb 4, 2017

I can't seem to reproduce so I'll just re-open if I see again, same for others please if you see strangeness like this please re-open.

@bbondy bbondy closed this as completed Feb 4, 2017
@bbondy bbondy removed this from the 0.13.2 milestone Feb 4, 2017
@cndouglas cndouglas removed the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Mar 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants