put some "shine" on the ledger notifications

[mrose17]

example 1: if the client can't retrieve the data, how does it know that the account is under balance. seems to me that the "Your account..." status shouldn't be there:

example 2: at the top we're told we have less than 24h to review (great!), but the status gives a date for the next contribution (confusing). i suggest that when <=24h, that the status indicate how long until the contribution. (hint: use the magnificent moment package, e.g. moment.fromNow(true)):

example 3: when funds are pending, i don't think it makes sense to talk about a 'Next contribution':

example 4: if the contribution date is in the past (this screenshot was taken on 9/15), and the balance is sufficient, then instead of "Next contribution" we ought to have something like "Contribution being processed":

[bradleyrichter]

example 1: Agreed. Status report should switch to something like: Status update not available. Please check your internet connection and try again.

example 2: seems like P2 polish to me.

ex 3: why not? If it's tomorrow, then hurry up!

ex 4: different problem - the contribution date can never be in the past. In this case, always make it the same day?

[mrose17]

also note that in example 2, there is no "Later" button. there should be. otherwise, the only way to get the notification to go away is to click "Review your chosen sites".

[bradleyrichter]

One point I forgot to make here. Most likely, the top bar notifications will not be seen together with ledger screen until user clicks on the CTA button.

#2 needs an "Ok" button. I think 24h later is already later. No?

[mrose17]

i suspect that if the active tab is about:preferences#payments then notifications shouldn't be seen. i don't know whether they should be discarded or re-scheduled.

@diracdeltas & @ayumi - your thoughts?

[mrose17]

@bsclifton - can we close this issue now?

[bsclifton]

@mrose17 absolutely- @luixxiul has done a killer job with the CSS

From here on out, we can open issues as-needed 😄 There are existing issues for some of the above

[mrose17]

groovy!

[luixxiul]

While I haven't tweaked something on the notification bar?

[mrose17]

@luixxiul - i think that as a part of some general refactoring, the notification bar issue above was polished... so, we're done with this issue!

[luixxiul]

sweet!