Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Browsing history is not cleared for saved and restored tabs #2528

Closed
luixxiul opened this issue Jul 17, 2016 · 5 comments
Closed

Browsing history is not cleared for saved and restored tabs #2528

luixxiul opened this issue Jul 17, 2016 · 5 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 17, 2016

Describe the issue you encountered:
#2513 (comment)
I checked the Private Data options, but browsing history is not cleared when I have selected "my windows/tabs from last time" in the option of "Brave start with".

  • Platform (Win7, 8, 10? macOS? Linux distro?): OS X
  • Brave Version: 0.11.1 Beta1
  • Steps to reproduce:
    1. Select "my windows/tabs from last time" on about:preferences
    2. Open a URL in a tab
    3. Check Private Data options on about:preferences#security
    4. Restart Brave

Setting a milestone for now.

@luixxiul luixxiul added this to the 0.11.1dev milestone Jul 17, 2016
@bbondy
Copy link
Member

bbondy commented Jul 18, 2016

I think this is working like it should. CC @diracdeltas to see what she thinks.
I don't think any of these: Browsing history, download history, cached images and files, all site cookies are for opened tabs.

I could kind of see how Browsing history could be considered opened frames, but I think it's easy enough to discover the other option when you see tabs restored.

@bbondy bbondy removed this from the 0.11.1dev milestone Jul 18, 2016
@diracdeltas
Copy link
Member

i think if "my windows/tabs from last time" is the value of "Brave start with" and all data is supposed to be cleared when the browser closes, i would expect at least cookies to be cleared for the open tabs when the browser closes. Maybe cache too.

@bbondy
Copy link
Member

bbondy commented Jul 19, 2016

those will be cleared, it's just the list of URLs will repopulate the cache when it loads then when you first focus the tab (and for the active tab)

@diracdeltas
Copy link
Member

sgtm

@bbondy
Copy link
Member

bbondy commented Jul 20, 2016

ok closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants