Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Use System default Fonts #2324

Closed
stanleyxu2005 opened this issue Jun 28, 2016 · 9 comments
Closed

Use System default Fonts #2324

stanleyxu2005 opened this issue Jun 28, 2016 · 9 comments

Comments

@stanleyxu2005
Copy link

I'm using Brave 0.10.4 on Win7. I really love this application. I notice one optical issue: The font of Win7 is usually "Segoe UI 9pt", but I guess Brave uses "Arial" or something else overall on Tab, Menu, Adressbar and Bookmark Toolbar.

Do you mind to use system font by default?

@bradleyrichter
Copy link
Contributor

Thanks @stanleyxu2005!

@bbondy We recently talked about this but I'm not sure if we found the answer? There may be a bug if the default is not appearing.

@stanleyxu2005
Copy link
Author

stanleyxu2005 commented Jun 29, 2016

In the less folder, there is only font size definition, but no font face definition. I don't know, if you can add a font face and give a try. For windows it will be "segoe ui" (9pt), for mac and linux, the setting is different.

@bradleyrichter
Copy link
Contributor

Perhaps having no definition was supposed to allow the default system font to work.

LMK if you find a solution...

@luixxiul
Copy link
Contributor

luixxiul commented Jun 30, 2016

+1, on 0.10.4 the Japanese characters are poorly rendered.

I assume the different font sets are used at the same time. Chinese and Japanese characters mixed on Gmail. I think I didn't experience this on 0.10.3.

#2929

@stanleyxu2005
Copy link
Author

stanleyxu2005 commented Aug 17, 2016

I don't know if you can change fonts when creating a BrowserWindow.
I see something interesting.

const win = new BrowserWindow({
  webPreferences: {
    defaultFontFamily: {
      sansSerif: 'segoe ui' // can also try "'segoe ui',arial"
    }
  }
});

https://github.com/electron/electron/blob/master/docs/api/browser-window.md

If this gonna work, I think the value can be provided in settings window.

@darkdh
Copy link
Member

darkdh commented Oct 11, 2016

@stanleyxu2005
Copy link
Author

@bradleyrichter I think the recent release has changed the font settings. It looks much better for ASCII chars. But for Chinese and Japanese chars, I still think there can do some tweaks. It would be great, if there is a config file we can customize and test. I don't really have the environment to build Brave from scratch, just for some tweak font tuning. Thanks

@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
@leavehouse
Copy link

+1 from me. Chrome and all Chrome-based alternative browsers (like Brave) have this defect, and it's quite annoying. I'm on Ubuntu and use a system font size of 14, but Brave doesn't respect this for tab titles or the address bar, so the text is unreadably small.

@bsclifton
Copy link
Member

Closing in favor of brave/brave-browser#696

@bsclifton bsclifton added wontfix post-v1 We don't expect to be able to resolve this before releasing v1.0 with Brave Core (instead of Muon). labels Aug 7, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 7, 2018
@bsclifton bsclifton added open-in-brave-core and removed post-v1 We don't expect to be able to resolve this before releasing v1.0 with Brave Core (instead of Muon). labels Aug 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants