Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

"recently closed tabs" should be global, not per window #10002

Closed
bridiver opened this issue Jul 16, 2017 · 1 comment
Closed

"recently closed tabs" should be global, not per window #10002

bridiver opened this issue Jul 16, 2017 · 1 comment
Labels
refactoring stale

Comments

@bridiver
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    closedFrames is stored in perWindowState and should be stored once in global state

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    ff263c0
@bsclifton
Copy link
Member

Related: the menu code makes an attempt at this (for use w/ the History menu)

browser-laptop/app/browser/menu.js

Line 681 in 9b64f58

closedFrames = closedFrames.set(tab.get('url'), tab.get('frame'))

@ghost ghost mentioned this issue Jul 28, 2017
Closed
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton added the stale label Sep 1, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
refactoring stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bridiver @bsclifton