Merge pull request #8645 from brave/fix/local-pdf-2

allow PDFJS to load local files

Author: bbondy

app/extensions.js

@@ -408,6 +408,9 @@ module.exports.init = () => {
   }
 
   let loadExtension = (extensionId, extensionPath, manifest = {}, manifestLocation = 'unpacked') => {
+    if (extensionId === config.PDFJSExtensionId) {
+      manifestLocation = 'component'
+    }
     if (!extensionInfo.isLoaded(extensionId) && !extensionInfo.isLoading(extensionId)) {
       extensionInfo.setState(extensionId, extensionStates.LOADING)
       if (extensionId === config.braveExtensionId || extensionId === config.torrentExtensionId || extensionId === config.syncExtensionId) {

app/filtering.js

@@ -592,7 +592,7 @@ const initPartition = (partition) => {
 }
 module.exports.initPartition = initPartition
 
-const filterableProtocols = ['http:', 'https:', 'ws:', 'wss:', 'magnet:']
+const filterableProtocols = ['http:', 'https:', 'ws:', 'wss:', 'magnet:', 'file:']
 
 function shouldIgnoreUrl (details) {
   // internal requests
@@ -676,6 +676,9 @@ module.exports.isResourceEnabled = (resourceName, url, isPrivate) => {
     return true
   }
 
+  if (resourceName === 'pdfjs') {
+    return getSetting(settings.PDFJS_ENABLED)
+  }
   if (resourceName === 'webtorrent') {
     return getSetting(settings.TORRENT_VIEWER_ENABLED)
   }

app/index.js

@@ -65,6 +65,7 @@ const TrackingProtection = require('./trackingProtection')
 const AdBlock = require('./adBlock')
 const AdInsertion = require('./browser/ads/adInsertion')
 const HttpsEverywhere = require('./httpsEverywhere')
+const PDFJS = require('./pdfJS')
 const SiteHacks = require('./siteHacks')
 const CmdLine = require('./cmdLine')
 const UpdateStatus = require('../js/constants/updateStatus')
@@ -338,6 +339,7 @@ app.on('ready', () => {
     TrackingProtection.init()
     AdBlock.init()
     AdInsertion.init()
+    PDFJS.init()
 
     if (!loadedPerWindowState || loadedPerWindowState.length === 0) {
       if (!CmdLine.newWindowURL()) {

app/pdfJS.js

@@ -0,0 +1,35 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+'use strict'
+
+const UrlUtil = require('../js/lib/urlutil')
+const Filtering = require('./filtering')
+const config = require('../js/constants/config')
+const appActions = require('../js/actions/appActions')
+const getSetting = require('../js/settings').getSetting
+const settings = require('../js/constants/settings')
+
+const pdfjsBaseUrl = `chrome-extension://${config.PDFJSExtensionId}/`
+const viewerBaseUrl = `${pdfjsBaseUrl}content/web/viewer.html`
+
+const onBeforeRequest = (details) => {
+  const result = { resourceName: 'pdfjs' }
+  if (!(details.resourceType === 'mainFrame' &&
+    UrlUtil.isFileScheme(details.url) &&
+    UrlUtil.isFileType(details.url, 'pdf'))) {
+    return result
+  }
+  appActions.loadURLRequested(details.tabId, `${viewerBaseUrl}?file=${encodeURIComponent(details.url)}`)
+  result.cancel = true
+  return result
+}
+
+/**
+ * Load PDF.JS
+ */
+module.exports.init = () => {
+  if (getSetting(settings.PDFJS_ENABLED)) {
+    Filtering.registerBeforeRequestFilteringCB(onBeforeRequest)
+  }
+}

test/unit/lib/urlutilTest.js

@@ -254,6 +254,10 @@ describe('urlutil', function () {
       assert.equal(UrlUtil.getLocationIfPDF('chrome-extension://blank'), 'chrome-extension://blank')
       assert.equal(UrlUtil.getLocationIfPDF(null), null)
     })
+    it('gets location for file: PDF URL', function () {
+      let url = 'chrome-extension://jdbefljfgobbmcidnmpjamcbhnbphjnb/file:///Users/yan/Downloads/test.pdf'
+      assert.equal(UrlUtil.getLocationIfPDF(url), 'file:///Users/yan/Downloads/test.pdf')
+    })
   })
 
   describe('getDisplayLocation', function () {