Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Commit 8f59a3b

Browse files
authored
Merge pull request #8300 from luixxiul/hotfix-navbarHeight
Increase the tabs bar and tabsToolbarButtons height
2 parents 32d3091 + 7453183 commit 8f59a3b

File tree

4 files changed

+11
-4
lines changed

4 files changed

+11
-4
lines changed

app/renderer/components/styles/global.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ const globalStyles = {
108108
buttonWidth: '25px',
109109
navbarHeight: '36px',
110110
downloadsBarHeight: '50px',
111-
tabsToolbarHeight: '28px',
111+
tabsToolbarHeight: '26px',
112112
tabPagesHeight: '7px',
113113
bookmarksToolbarHeight: '24px',
114114
bookmarksToolbarWithFaviconsHeight: '24px',
@@ -210,4 +210,6 @@ globalStyles.color.activeTabDefaultColor = globalStyles.color.chromePrimary
210210
globalStyles.color.switchBG_on = globalStyles.color.braveOrange
211211
globalStyles.color.statsGray = globalStyles.color.chromeText
212212

213+
globalStyles.spacing.tabHeight = globalStyles.spacing.tabsToolbarHeight
214+
213215
module.exports = globalStyles

app/renderer/components/styles/tab.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const styles = StyleSheet.create({
1818
boxSizing: 'border-box',
1919
color: '#5a5a5a',
2020
display: 'flex',
21-
height: '24px',
21+
height: globalStyles.spacing.tabHeight,
2222
marginTop: '0',
2323
transition: `transform 200ms ease, ${globalStyles.transition.tabBackgroundTransition}`,
2424
left: '0',
@@ -94,7 +94,7 @@ const styles = StyleSheet.create({
9494

9595
active: {
9696
background: `rgba(255, 255, 255, 1.0)`,
97-
height: '24px',
97+
height: globalStyles.spacing.tabHeight,
9898
marginTop: '0',
9999
borderWidth: '0 1px 0 0',
100100
borderStyle: 'solid',

less/tabs.less

+4
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@
119119
}
120120

121121
.tabsToolbar {
122+
box-sizing: border-box;
122123
background: @tabsBackground;
123124
display: flex;
124125
height: @tabsToolbarHeight;
@@ -127,7 +128,10 @@
127128
}
128129

129130
.tabsToolbarButtons {
131+
box-sizing: border-box;
132+
height: @tabHeight;
130133
padding-right: 2px;
134+
131135
.browserButton {
132136
display: inline-block;
133137
line-height: 26px;

less/variables.less

+2-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,8 @@
8181

8282
@navbarHeight: 36px;
8383
@downloadsBarHeight: 60px;
84-
@tabsToolbarHeight: 24px;
84+
@tabsToolbarHeight: 26px;
85+
@tabHeight: @tabsToolbarHeight;
8586
@tabPagesHeight: 7px;
8687
@bookmarksToolbarHeight: 24px;
8788
@bookmarksToolbarWithFaviconsHeight: 24px;

0 commit comments

Comments
 (0)