Merge pull request #7988 from Liunkae/download-confirmation-l10

luixxiul · web-flow · commit 7c2e1013a210 · 2017-03-31T12:32:58.000+09:00
Localize download delete confirmation
diff --git a/app/extensions/brave/locales/en-US/downloads.properties b/app/extensions/brave/locales/en-US/downloads.properties
@@ -7,6 +7,7 @@ downloadCompleted=Completed
 downloadInProgress=Downloading: {{downloadPercent}}
 downloadInProgressUnknownTotal=Downloading…
 downloadPaused=Paused: {{downloadPercent}}
+downloadDeleteConfirmation=Delete?
 
 downloadPause.title=Pause Download
 downloadResume.title=Resume Download
diff --git a/app/renderer/components/downloadItem.js b/app/renderer/components/downloadItem.js
@@ -91,7 +91,7 @@ class DownloadItem extends ImmutableComponent {
       })}>
       {
         this.props.deleteConfirmationVisible
-        ? <div className='deleteConfirmation'>Delete?<Button l10nId='ok' className='primaryButton confirmDeleteButton' onClick={this.onDeleteDownload} /></div>
+        ? <div className='deleteConfirmation'><span data-l10n-id='downloadDeleteConfirmation' /><Button l10nId='ok' className='primaryButton confirmDeleteButton' onClick={this.onDeleteDownload} /></div>
         : null
       }
       <div className='downloadActions'>

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ class DownloadItem extends ImmutableComponent {`
`91`	`91`	`})}>`
`92`	`92`	`{`
`93`	`93`	`this.props.deleteConfirmationVisible`
`94`		`- ? <div className='deleteConfirmation'>Delete?<Button l10nId='ok' className='primaryButton confirmDeleteButton' onClick={this.onDeleteDownload} /></div>`
	`94`	`+ ? <div className='deleteConfirmation'><span data-l10n-id='downloadDeleteConfirmation' /><Button l10nId='ok' className='primaryButton confirmDeleteButton' onClick={this.onDeleteDownload} /></div>`
`95`	`95`	`: null`
`96`	`96`	`}`
`97`	`97`	`<div className='downloadActions'>`