Implement copy as a local shortcut on OS X

Potential workaround for #1060

Auditors: @bbondy

Author: diracdeltas

app/localShortcuts.js

@@ -36,6 +36,12 @@ module.exports.register = (win) => {
       const focusedWindow = win || BrowserWindow.getFocusedWindow()
       focusedWindow.setFullScreen(!focusedWindow.isFullScreen())
     })
+  } else {
+    // Workaround for #1060
+    simpleWebContentEvents.push([
+      'Cmd+C',
+      messages.SHORTCUT_ACTIVE_FRAME_COPY
+    ])
   }
 
   // Tab ordering shortcuts

js/components/frame.js

@@ -17,6 +17,7 @@ const contextMenus = require('../contextMenus')
 const config = require('../constants/config.js')
 const siteHacks = require('../data/siteHacks')
 const ipc = global.require('electron').ipcRenderer
+const clipboard = global.require('electron').clipboard
 const FullScreenWarning = require('./fullScreenWarning')
 const debounce = require('../lib/debounce.js')
 const getSetting = require('../settings').getSetting
@@ -297,6 +298,14 @@ class Frame extends ImmutableComponent {
       case 'load-non-navigatable-url':
         this.webview.loadURL(this.props.frame.get('activeShortcutDetails'))
         break
+      case 'copy':
+        let selection = window.getSelection()
+        if (selection && selection.toString()) {
+          clipboard.writeText(selection.toString())
+        } else {
+          this.webview.copy()
+        }
+        break
     }
     if (activeShortcut) {
       windowActions.setActiveFrameShortcut(this.props.frame, null, null)

js/constants/messages.js

@@ -27,6 +27,7 @@ const messages = {
   SHORTCUT_ACTIVE_FRAME_BOOKMARK: _,
   SHORTCUT_ACTIVE_FRAME_REMOVE_BOOKMARK: _,
   SHORTCUT_ACTIVE_FRAME_LOAD_URL: _, /** @arg {string} url to load */
+  SHORTCUT_ACTIVE_FRAME_COPY: _,
   // Frame management shortcuts
   SHORTCUT_NEW_FRAME: _, /** @arg {string} opt_url to load if any */
   SHORTCUT_CLOSE_FRAME: _, /** @arg {number} opt_key of frame, defaults to active frame */

js/stores/windowStore.js

@@ -604,7 +604,7 @@ ipc.on(messages.IMPORT_BOOKMARKS, () => {
   }
 })
 
-const frameShortcuts = ['stop', 'reload', 'zoom-in', 'zoom-out', 'zoom-reset', 'toggle-dev-tools', 'clean-reload', 'view-source', 'mute', 'save', 'print', 'show-findbar']
+const frameShortcuts = ['stop', 'reload', 'zoom-in', 'zoom-out', 'zoom-reset', 'toggle-dev-tools', 'clean-reload', 'view-source', 'mute', 'save', 'print', 'show-findbar', 'copy']
 frameShortcuts.forEach((shortcut) => {
   // Listen for actions on the active frame
   ipc.on(`shortcut-active-frame-${shortcut}`, () => {