Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Commit 62c707a

Browse files
committed
Update default for magic titlebar on Windows/Linux; add favicon for about:autofill + about:passwords
Auditors: @BradRichter, @darkdh Fixes #5416 (URL bar duplicates the title bar) 1. Install Brave (fresh install or move session folder) on Linux 2. Launch Brave and visit brave.com 3. URL bar should always be showing 4. Go to about:preferences and ensure "Always show URL bar" is enabled 1. Install Brave (fresh install or move session folder) on Windows 2. Launch Brave and visit brave.com 3. URL bar should be hidden unless mouse is in there 4. Go to about:preferences and ensure "Always show URL bar" is disabled Fixes #5398 (about:autofill missing Brave favicon) 1. Launch Brave and visit about:about 2. Click about:passwords and notice the favicon now shows up 3. Click about:autofill and notice the favicon now shows up
1 parent ad0a77b commit 62c707a

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

app/extensions/brave/about-autofill.html

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
<meta name="availableLanguages" content="">
99
<meta name="defaultLanguage" content="en-US">
1010
<meta name='theme-color' content='#ff5000'>
11+
<link rel="shortcut icon"type="image/x-icon" href="data:image/x-icon;,">
1112
<title data-l10n-id="autofillTitle"></title>
1213
<script src='js/about.js'></script>
1314
<script src="ext/l20n.min.js" async></script>

app/extensions/brave/about-passwords.html

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
<meta name="availableLanguages" content="">
99
<meta name="defaultLanguage" content="en-US">
1010
<meta name='theme-color' content='#ff5000'>
11+
<link rel="shortcut icon"type="image/x-icon" href="data:image/x-icon;,">
1112
<title data-l10n-id="passwordsTitle"></title>
1213
<script src='js/about.js'></script>
1314
<script src="ext/l20n.min.js" async></script>

js/constants/appConfig.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ module.exports = {
133133
'security.passwords.dashlane-enabled': false,
134134
'security.passwords.last-pass-enabled': false,
135135
'general.downloads.default-save-path': null,
136-
'general.disable-title-mode': process.platform === 'win32',
136+
'general.disable-title-mode': process.platform === 'linux',
137137
'advanced.hardware-acceleration-enabled': true,
138138
'advanced.default-zoom-level': null,
139139
'advanced.pdfjs-enabled': true,

0 commit comments

Comments
 (0)