Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Commit 6228f41

Browse files
committed
Use ImmutableJS correctly for frameOpts
This is already covered by misc-components automated tests, several were failing that I didn't know were related. Fix #10376 Auditors: @bsclifton
1 parent e3e2855 commit 6228f41

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

js/stores/appStore.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -216,9 +216,9 @@ const createWindow = (action) => {
216216
} else {
217217
if (frameOpts && Object.keys(frameOpts).length > 0) {
218218
if (frameOpts.forEach) {
219-
frames = Immutable.toJS(frameOpts)
219+
frames = Immutable.fromJS(frameOpts)
220220
} else {
221-
frames.push(frameOpts)
221+
frames = frames.push(Immutable.fromJS(frameOpts))
222222
}
223223
} else if (startupSetting === 'homePage' && homepageSetting) {
224224
frames = Immutable.fromJS(homepageSetting.split('|').map((homepage) => {

0 commit comments

Comments
 (0)