Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Commit 53e3725

Browse files
authored
Merge pull request #9481 from NejcZdovc/redux/object-assign
Remove object assign in merge props
2 parents 9e74130 + c0b1833 commit 53e3725

File tree

6 files changed

+9
-6
lines changed

6 files changed

+9
-6
lines changed

app/renderer/components/common/messageBox.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ class MessageBox extends React.Component {
117117
props.cancelId = messageBoxDetail.get('cancelId')
118118
props.isActive = frameStateUtil.isFrameKeyActive(currentWindow, tab.getIn(['frame', 'key']))
119119

120-
return Object.assign({}, ownProps, props)
120+
return props
121121
}
122122

123123
render () {

app/renderer/components/frame/frame.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -926,6 +926,7 @@ class Frame extends React.Component {
926926
props.showMessageBox = tabMessageBoxState.hasMessageBoxDetail(state, tabId)
927927

928928
// used in other functions
929+
props.frameKey = ownProps.frameKey
929930
props.urlBarFocused = frame && frame.getIn(['navbar', 'urlbar', 'focused'])
930931
props.isAutFillContextMenu = contextMenu && contextMenu.get('type') === 'autofill'
931932
props.isSecure = frame.getIn(['security', 'isSecure'])
@@ -954,7 +955,7 @@ class Frame extends React.Component {
954955
props.tabUrl = tab && tab.get('url')
955956
props.partitionNumber = frame.get('partitionNumber')
956957

957-
return Object.assign({}, ownProps, props)
958+
return props
958959
}
959960

960961
render () {

app/renderer/components/navigation/browserAction.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ class BrowserAction extends React.Component {
6666

6767
const props = {}
6868
// used in renderer
69+
props.extensionId = ownProps.extensionId
6970
props.title = browserActions.get('title')
7071
props.text = browserActions.get('text')
7172
props.color = browserActions.get('color')
@@ -75,7 +76,7 @@ class BrowserAction extends React.Component {
7576
props.popupWindowSrc = currentWindow.getIn(['popupWindowDetail', 'src'])
7677
props.activeTabId = activeTabId
7778

78-
return Object.assign({}, ownProps, props)
79+
return props
7980
}
8081

8182
render () {

app/renderer/components/navigation/menuBar.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ class MenuBar extends React.Component {
133133
props.contextMenuDetail = !!contextMenuDetail
134134
props.lastFocusedSelector = currentWindow.getIn(['ui', 'menubar', 'lastFocusedSelector'])
135135

136-
return Object.assign({}, ownProps, props)
136+
return props
137137
}
138138

139139
render () {

app/renderer/components/navigation/menuBarItem.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ class MenuBarItem extends React.Component {
5252

5353
const props = {}
5454
// used in renderer
55+
props.index = ownProps.index
5556
props.selected = ownProps.index === selectedIndex
5657
props.label = template.get('label')
5758

@@ -60,7 +61,7 @@ class MenuBarItem extends React.Component {
6061
props.lastFocusedSelector = currentWindow.getIn(['ui', 'menubar', 'lastFocusedSelector'])
6162
props.selectedIndex = selectedIndex
6263

63-
return Object.assign({}, ownProps, props)
64+
return props
6465
}
6566

6667
render () {

app/renderer/components/navigation/navigator.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ class Navigator extends React.Component {
191191
props.isNavigable = activeFrame && isNavigatableAboutPage(getBaseUrl(activeFrame.get('location')))
192192
props.activeTabId = activeTabId
193193

194-
return Object.assign({}, ownProps, props)
194+
return props
195195
}
196196

197197
render () {

0 commit comments

Comments
 (0)