Remove unused clone frame code

Auditors: @bridiver

Author: bbondy

docs/windowActions.md

@@ -221,18 +221,6 @@ Dispatches a message to the store to create a new frame
 
 
 
-### cloneFrame(frameProps, guestInstanceId) 
-
-Dispatches a message to the store to clone an existing frame
-
-**Parameters**
-
-**frameProps**: `Object`, The properties of the frame to clone
-
-**guestInstanceId**: `number`, The guestInstanceId of the cloned webcontents
-
-
-
 ### closeFrame(frames, frameProps) 
 
 Dispatches a message to close a frame

js/actions/windowActions.js

@@ -292,21 +292,6 @@ const windowActions = {
     })
   },
 
-  /**
-   * Dispatches a message to the store to clone an existing frame
-   *
-   * @param {Object} frameProps - The properties of the frame to clone
-   * @param {number} guestInstanceId - The guestInstanceId of the cloned webcontents
-   */
-  cloneFrame: function (frameProps, guestInstanceId, openInForeground) {
-    dispatch({
-      actionType: windowConstants.WINDOW_CLONE_FRAME,
-      frameOpts: frameProps.toJS ? frameProps.toJS() : frameProps,
-      guestInstanceId,
-      openInForeground
-    })
-  },
-
   /**
    * Dispatches a message to close a frame
    *

js/constants/windowConstants.js

@@ -10,7 +10,6 @@ const windowConstants = {
   WINDOW_SET_NAVBAR_INPUT: _,
   WINDOW_NEW_FRAME: _,
   WINDOW_VIEW_KEY: _,
-  WINDOW_CLONE_FRAME: _,
   WINDOW_CLOSE_FRAME: _,
   WINDOW_SET_ACTIVE_FRAME: _,
   WINDOW_SET_FOCUSED_FRAME: _,

js/state/frameStateUtil.js

@@ -242,38 +242,6 @@ function getPartition (frameOpts) {
   return partition
 }
 
-function cloneFrame (frameOpts, guestInstanceId, key) {
-  const cloneableAttributes = [
-    'audioMuted',
-    'canGoBack',
-    'canGoForward',
-    'icon',
-    'title',
-    'isPrivate',
-    'partitionNumber',
-    'themeColor',
-    'computedThemeColor'
-  ]
-  let clone = {}
-  cloneableAttributes.forEach((attr) => {
-    clone[attr] = frameOpts[attr]
-  })
-
-  clone.guestInstanceId = guestInstanceId
-  // copy the history
-  clone.history = frameOpts.history.slice(0)
-  // location is loaded by the webcontents
-  clone.delayedLoadUrl = frameOpts.location
-  clone.location = 'about:blank'
-  clone.src = 'about:blank'
-  clone.parentFrameKey = frameOpts.key
-  if (frameOpts.aboutDetails !== undefined) {
-    clone.aboutDetails = frameOpts.aboutDetails
-    clone.aboutDetails.frameKey = key
-  }
-  return clone
-}
-
 /**
  * Returns an object in the same format that was passed to it (ImmutableJS/POD)
  * for the subset of frame data that is used for tabs.
@@ -556,7 +524,6 @@ module.exports = {
   getFramePropsIndex,
   getFrameKeysByDisplayIndex,
   getPartition,
-  cloneFrame,
   addFrame,
   undoCloseFrame,
   removeFrame,

js/stores/windowStore.js

@@ -467,14 +467,6 @@ const doAction = (action) => {
     case windowConstants.WINDOW_VIEW_KEY:
       newFrame(action.frameOpts, action.openInForeground)
       break
-    case windowConstants.WINDOW_CLONE_FRAME:
-      {
-        let insertionIndex = frameStateUtil.findIndexForFrameKey(windowState.get('frames'), action.frameOpts.key) + 1
-        const nextKey = incrementNextKey()
-        newFrame(frameStateUtil.cloneFrame(action.frameOpts, action.guestInstanceId, nextKey),
-          action.openInForeground, insertionIndex, nextKey)
-        break
-      }
     case windowConstants.WINDOW_CLOSE_FRAME:
       // Use the frameProps we passed in, or default to the active frame
       const frameProps = action.frameProps || frameStateUtil.getActiveFrame(windowState)

test/unit/state/frameStateUtilTest.js

@@ -17,92 +17,6 @@ describe('frameStateUtil', function () {
     this.windowState = Immutable.fromJS(Object.assign({}, defaultWindowStore.toJS()))
   })
 
-  describe('cloneFrame', function () {
-    before(function () {
-      this.frameOpts = {
-        key: 1,
-        tabId: 2,
-        parentFrameKey: 3,
-        audioMuted: true,
-        canGoBack: true,
-        canGoForward: true,
-        icon: 'icon',
-        title: 'title',
-        isPrivate: true,
-        partitionNumber: 4,
-        themeColor: 'ffffff',
-        computedThemeColor: 'aaaaaa',
-        history: ['http://brave.com'],
-        location: 'http://brave.com/about'
-      }
-      this.aboutFrameOpts = {}
-      Object.assign(this.aboutFrameOpts, this.frameOpts)
-      this.aboutFrameOpts['aboutDetails'] =
-      {
-        errorCode: -1,
-        frameKey: 1
-      }
-      this.clonedFrame = frameStateUtil.cloneFrame(this.frameOpts, 4)
-      this.key = 6
-      this.aboutClonedFrame = frameStateUtil.cloneFrame(this.aboutFrameOpts, 5, this.key)
-    })
-
-    it('does not copy the key', function () {
-      assert.equal(this.frameOpts.key, 1)
-      assert.equal(this.clonedFrame.key, undefined)
-    })
-
-    it('does not copy the tabId', function () {
-      assert.equal(this.frameOpts.tabId, 2)
-      assert.equal(this.clonedFrame.tabId, undefined)
-    })
-
-    it('sets the parentFrameKey to frameOpts.key', function () {
-      assert.equal(this.frameOpts.parentFrameKey, 3)
-      assert.equal(this.clonedFrame.parentFrameKey, 1)
-    })
-
-    it('sets the delayedLoadUrl to frameOpts.location', function () {
-      assert.equal(this.clonedFrame.delayedLoadUrl, 'http://brave.com/about')
-    })
-
-    it('sets the location to about:blank', function () {
-      assert.equal(this.clonedFrame.location, 'about:blank')
-    })
-
-    it('sets the src to about:blank', function () {
-      assert.equal(this.clonedFrame.src, 'about:blank')
-    })
-
-    it('sets the guestInstanceId', function () {
-      assert.equal(this.clonedFrame.guestInstanceId, 4)
-    })
-
-    it('copies audioMuted, canGoBack, canGoForward, icon, title, isPrivate, partitionNumber, themeColor, computere and history', function () {
-      // attributes that should be copied
-      assert.equal(this.clonedFrame.audioMuted, true)
-      assert.equal(this.clonedFrame.canGoBack, true)
-      assert.equal(this.clonedFrame.canGoForward, true)
-      assert.equal(this.clonedFrame.icon, 'icon')
-      assert.equal(this.clonedFrame.title, 'title')
-      assert.equal(this.clonedFrame.isPrivate, true)
-      assert.equal(this.clonedFrame.partitionNumber, 4)
-      assert.equal(this.clonedFrame.themeColor, 'ffffff')
-      assert.equal(this.clonedFrame.computedThemeColor, 'aaaaaa')
-      assert.deepEqual(this.clonedFrame.history, ['http://brave.com'])
-      assert(this.clonedFrame.history !== this.frameOpts.history)
-    })
-
-    it('clone without aboutDetails', function () {
-      assert.equal(this.clonedFrame.aboutDetails, undefined)
-    })
-
-    it('copies aboutDetails with key', function () {
-      assert.equal(this.aboutClonedFrame.aboutDetails.errorCode, this.aboutFrameOpts.aboutDetails.errorCode)
-      assert.equal(this.aboutClonedFrame.aboutDetails.frameKey, this.key)
-    })
-  })
-
   describe('query', function () {
     before(function () {
       this.frames = Immutable.fromJS([