Fix issue @alexwykoff found while testing 0.14.0 RC2. Fixes are reinforced by unit tests

Auditors: @alexwykoff, @NejcZdovc

Author: bsclifton

app/common/state/extensionState.js

@@ -18,9 +18,13 @@ const extensionState = {
   },
 
   getEnabledExtensions: (state) => {
-    return state.get('extensions').filter((installInfo, extensionId) => {
-      return installInfo.get('enabled') === true
-    })
+    const extensions = state.get('extensions')
+    if (extensions) {
+      return extensions.filter((installInfo, extensionId) => {
+        return installInfo.get('enabled') === true
+      })
+    }
+    return Immutable.fromJS([])
   },
 
   getExtensionById: (state, extensionId) => {

js/contextMenus.js

@@ -39,6 +39,7 @@ const {bookmarksToolbarMode} = require('../app/common/constants/settingsEnums')
 const extensionState = require('../app/common/state/extensionState')
 const extensionActions = require('../app/common/actions/extensionActions')
 const appStore = require('./stores/appStoreRenderer')
+const {makeImmutable} = require('../app/common/state/immutableUtil')
 
 const isDarwin = process.platform === 'darwin'
 const isLinux = process.platform === 'linux'
@@ -951,12 +952,15 @@ function addLinkMenu (link, frame) {
 function mainTemplateInit (nodeProps, frame, tab) {
   let template = []
 
+  nodeProps = nodeProps || {}
+  frame = makeImmutable(frame || {})
+
   const isLink = nodeProps.linkURL && nodeProps.linkURL !== ''
   const isImage = nodeProps.mediaType === 'image'
   const isVideo = nodeProps.mediaType === 'video'
   const isAudio = nodeProps.mediaType === 'audio'
   const isInputField = nodeProps.isEditable || nodeProps.inputFieldType !== 'none'
-  const isTextSelected = nodeProps.selectionText.length > 0
+  const isTextSelected = nodeProps.selectionText && nodeProps.selectionText.length > 0
   const isAboutPage = aboutUrls.has(frame.get('location'))
 
   if (isLink) {
@@ -1022,7 +1026,10 @@ function mainTemplateInit (nodeProps, frame, tab) {
       }
     }
 
-    const editableItems = getEditableItems(nodeProps.selectionText, nodeProps.editFlags, true)
+    const editableItems = nodeProps.selectionText
+      ? getEditableItems(nodeProps.selectionText, nodeProps.editFlags, true)
+      : []
+
     template.push(...misspelledSuggestions, {
       label: locale.translation('undo'),
       accelerator: 'CmdOrCtrl+Z',

test/unit/js/contextMenusTest.js

@@ -0,0 +1,61 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+/* global describe, before, after, it */
+
+const mockery = require('mockery')
+const assert = require('assert')
+const sinon = require('sinon')
+let fakeElectronMenu
+let contextMenus
+require('../braveUnit')
+
+describe('Context menu module unit tests', function () {
+  const fakeLocale = {
+    translation: (token) => { return token }
+  }
+
+  before(function () {
+    mockery.enable({
+      warnOnReplace: false,
+      warnOnUnregistered: false,
+      useCleanCache: true
+    })
+    mockery.registerMock('electron', require('../lib/fakeElectron'))
+    mockery.registerMock('../js/l10n', fakeLocale)
+    contextMenus = require('../../../js/contextMenus')
+    fakeElectronMenu = require('../lib/fakeElectronMenu')
+  })
+
+  after(function () {
+    mockery.disable()
+  })
+
+  describe('onMainContextMenu', function () {
+    describe('when calling mainTemplateInit', function () {
+      let menuPopupSpy
+      let menuDestroySpy
+
+      before(function () {
+        menuPopupSpy = sinon.spy(fakeElectronMenu, 'popup')
+        menuDestroySpy = sinon.spy(fakeElectronMenu, 'destroy')
+      })
+
+      after(function () {
+        menuPopupSpy.restore()
+      })
+
+      it('calls menu.popup', function () {
+        menuPopupSpy.reset()
+        contextMenus.onMainContextMenu()
+        assert.equal(menuPopupSpy.calledOnce, true)
+      })
+
+      it('calls menu.destroy', function () {
+        menuDestroySpy.reset()
+        contextMenus.onMainContextMenu()
+        assert.equal(menuDestroySpy.calledOnce, true)
+      })
+    })
+  })
+})

test/unit/lib/fakeElectron.js

@@ -23,6 +23,11 @@ const fakeElectron = {
         isMaximized: () => false,
         webContents: {}
       }
+    },
+    Menu: {
+      buildFromTemplate: (template) => {
+        return require('./fakeElectronMenu')
+      }
     }
   },
   app: {

test/unit/lib/fakeElectronMenu.js

@@ -0,0 +1,6 @@
+const fakeElectronMenu = {
+  popup: () => {},
+  destroy: () => {}
+}
+
+module.exports = fakeElectronMenu