Fix extension ID for PDFJS

Fix #2529

This was failing to load for me I think because the PDFJS_ORIGIN ID was different from the one installed. It's unclear to me if the new one that I have that is in use by my instance will be the same for everyone.  This works concistently for me though and keeps the 2 IDs in sync

Auditors: @bridiver

Author: bbondy

app/extensions.js

@@ -132,7 +132,6 @@ let generateBraveManifest = () => {
 }
 
 let defaultExtensions = {
-  PDFJS: 'oemmndcbldboiebfnladdacbdfmadadm',
   OnePassword: 'aomjjhallfgjeglblehebfpbcfeobpgk',
   Dashlane: 'fdjamakpfbbddfjaooikfcpapjohcfmg',
   LastPass: 'hdokiejnpimakedhajhdlcegeplioahd'
@@ -181,10 +180,10 @@ module.exports.init = () => {
     installExtension(config.braveExtensionId, getExtensionsPath('brave'), {manifest_location: 'component', manifest: generateBraveManifest()})
 
     if (getSetting(settings.PDFJS_ENABLED)) {
-      installExtension(defaultExtensions.PDFJS, getExtensionsPath('pdfjs'))
-      enableExtension(defaultExtensions.PDFJS)
+      installExtension(config.PDFJSExtensionId, getExtensionsPath('pdfjs'))
+      enableExtension(config.PDFJSExtensionId)
     } else {
-      disableExtension(defaultExtensions.PDFJS)
+      disableExtension(config.PDFJSExtensionId)
     }
 
     if (getSetting(settings.ONE_PASSWORD_ENABLED)) {

js/constants/config.js

@@ -40,5 +40,6 @@ module.exports = {
     authUrl: (userId) => `${vaultHost}/v1/users/${userId}`,
     replacementUrl: adHost
   },
-  braveExtensionId: 'mnojpmjdmbbfmejpflffifhffcmidifd'
+  braveExtensionId: 'mnojpmjdmbbfmejpflffifhffcmidifd',
+  PDFJSExtensionId: 'ckglimbbooghmggmkikhbolcfmgniemo'
 }

js/stores/windowStore.js

@@ -36,7 +36,7 @@ let windowState = Immutable.fromJS({
 let lastEmittedState
 
 const CHANGE_EVENT = 'change'
-const PDFJS_ORIGIN = 'chrome-extension://adnmjfhcejodgpaljdmlmjoclihpcfka/'
+const PDFJS_ORIGIN = `chrome-extension://${config.PDFJSExtensionId}/`
 
 const frameStatePath = (key) =>
   ['frames', FrameStateUtil.findIndexForFrameKey(windowState.get('frames'), key)]