Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Commit 019a910

Browse files
committed
Make sure findbar selected state always gets reset
This was failing re-selections when there was a background tab I think the bug is too obscure to be useful as an automated test though, we already have a generic test for testing re-selections. Fix #5575 Auditors: @diracdeltas
1 parent 7d7c79b commit 019a910

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

js/components/findbar.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ class FindBar extends ImmutableComponent {
8282
this.searchInput.value = this.searchString
8383
this.focus()
8484
this.select()
85-
windowActions.setFindbarSelected(false)
85+
windowActions.setFindbarSelected(this.frame, false)
8686
}
8787

8888
componentWillUpdate (nextProps) {
@@ -97,7 +97,7 @@ class FindBar extends ImmutableComponent {
9797
// Findbar might already be focused, so make sure select happens even if no
9898
// onFocus event happens.
9999
this.select()
100-
windowActions.setFindbarSelected(false)
100+
windowActions.setFindbarSelected(this.frame, false)
101101
}
102102
if (!this.props.findDetail || !prevProps.findDetail ||
103103
this.props.findDetail.get('searchString') !== prevProps.findDetail.get('searchString') ||

0 commit comments

Comments
 (0)