Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample colors should be consistent #200

Open
khaki32 opened this issue Apr 30, 2022 · 1 comment
Open

Sample colors should be consistent #200

khaki32 opened this issue Apr 30, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@khaki32
Copy link
Contributor

khaki32 commented Apr 30, 2022

If a project is small enough for this to be reasonable, each color in a track preview should only be linked to one sample.
Screenshot 2022-04-30 21 15 32
Here it looks like there's only one sample in Drums, but there's actually two. That can be a little confusing.

@brandongregoryscott brandongregoryscott added the bug Something isn't working label May 1, 2022
@brandongregoryscott
Copy link
Owner

Ah, yeah, I figured this would happen from time to time. I only picked a small set of colors from the Evergreen theme that were easy to see on the card background to map by the file/sample id in src/utils/theme-utils.ts

This list could be expanded to include non-Evergreen shades or a more sophisticated hashing algorithm could be used to reduce collisions - open to ideas! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants